BlueCryptor icon indicating copy to clipboard operation
BlueCryptor copied to clipboard

Removed support for cryptographically broken algorithms MD2, MD4, MD5

Open LowAmmo opened this issue 3 years ago • 23 comments

Addresses the deprecation that has been there since iOS 13

Also added a project file to the repo to make future maintenance easier

Description

  • Removing all the code supporting MD2, MD4, MD5
    • They have been deprecated by Apple for being cryptographically broken
    • Cleans up warnings seen by anyone targeting an iOS version >13.0
  • Also included a project file to make future updates & testing easier

Motivation and Context

Issue: #77

Trying to eliminate warnings we see in our application (from consuming SwiftJWT, which consumes this)

How Has This Been Tested?

Unit testing in the repo/code. Also verified passivity in our application.

Checklist:

  • [x] I have submitted a CLA form (as on other PRs, submitted one electronically, so, assuming that would apply to this, too?)
  • [x] If applicable, I have updated the documentation accordingly.
  • [x] If applicable, I have added tests to cover my changes.

LowAmmo avatar Sep 30 '22 21:09 LowAmmo

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 30 '22 21:09 sonarqubecloud[bot]

@dannys42, @mman - Modified the PR to clean things up and match the other related repos that just rely on loading the Package.swift to dynamically generate the xcode project, etc.

LowAmmo avatar Feb 28 '23 18:02 LowAmmo

@LowAmmo I took a quick look and it LGTM. I will have to get some time to pull your branch and see whether the compilation will be clean... thanks!

mman avatar Feb 28 '23 18:02 mman

@dannys42, @mman - Modified the PR to clean things up and match the other related repos that just rely on loading the Package.swift to dynamically generate the xcode project, etc.

Tried your fork in my project and it builds cleanly now! LGTM!

mman avatar Mar 07 '23 16:03 mman

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Mar 28 '23 23:03 sonarqubecloud[bot]