screenFetch icon indicating copy to clipboard operation
screenFetch copied to clipboard

Screenfetch does not work as expected on macos Big Sur 11.0.1

Open ridhwaans opened this issue 4 years ago • 14 comments

I'm submitting a ... (check one with "x")

[ x] bug report

image

On macos Big Sur version 11.0.1, see screenshot for errors
Previously on Catalina before upgrading, screenfetch used to print a multi colored apple logo ascii art,
print 64bit Mac OS X 10.15, x86_64 Darwin along with correct information about shell, resolution, gpu, ram, uptime etc

ridhwaans avatar Nov 13 '20 05:11 ridhwaans

solution:

due to the output from /usr/bin/sw_vers was changed as:

$ /usr/bin/sw_vers
ProductName:	macOS
ProductVersion:	11.0.1
BuildVersion:	20B29

So, the issue can be manual fixed by modify Line 1057:

					if [[ -x /usr/bin/sw_vers ]] && /usr/bin/sw_vers | grep -E '\s*[mM]ac\s*OS\s*X?' >/dev/null; then
						distro="Mac OS X"

By using grep -E '\s*[mM]ac\s*OS\s*X?' instead of grep -i 'Mac OS X'

to match both Mac OS X or macOS in lower or higher version.

example: Screen Shot 2020-11-13 at 5 05 24 PM

marslo avatar Nov 13 '20 08:11 marslo

@marslo please make a PR

ridhwaans avatar Nov 14 '20 18:11 ridhwaans

There's a PR right here: https://github.com/KittyKatt/screenFetch/pull/681/commits/f7200af70c527ec01133eef501cab3dbae51688a

donn avatar Nov 24 '20 04:11 donn

I still have that problem on a M1 Mac. I used the latest source code from Github.

arian81 avatar Dec 16 '20 02:12 arian81

Hello Is there a timeline for the resolution of this issue? Running a macbook pro 2019 and reinstalled using brew. Thanks

Svartingknas avatar Jan 21 '21 01:01 Svartingknas

It was fixed here: https://github.com/KittyKatt/screenFetch/commit/f7200af70c527ec01133eef501cab3dbae51688a

darealshinji avatar Jan 21 '21 14:01 darealshinji

it's fixed in master, but there hasn't been a release cut with this change

pgoggijr avatar May 17 '21 15:05 pgoggijr

I still have that problem on a M1 Mac. I used the latest source code from Github.

I try now and its very easy man, just go this way;

This work for me in M1

$ sudo vim /opt/homebrew/Cellar/screenfetch/3.9.1/bin/screenfetch

This work for me in Intel chip

$ sudo vim /usr/local/Cellar/screenfetch/3.9.1/bin/screenfetch

Just diff installation directory of homebrew packages

Then go to the line 1057: like @marslo told and replace the line

if [[ -x /usr/bin/sw_vers ]] && /usr/bin/sw_vers | grep -E '\s*[mM]ac\s*OS\s*X?' >/dev/null; then
						distro="Mac OS X"

Restart your terminal and done!

marcus-gomes-v avatar Feb 24 '22 20:02 marcus-gomes-v

Can confirm, fixed it for me as well. Thank you @marslo . Can we cut a new release @KittyKatt ?

johnpekcan avatar Sep 28 '22 16:09 johnpekcan

Yes, might need to be in a couple of days if that's okay?

KittyKatt avatar Sep 28 '22 17:09 KittyKatt

Yup yup, we can most certainly handle that 😇 , thank you @KittyKatt !

johnpekcan avatar Sep 28 '22 18:09 johnpekcan

Please add this to the next release. Thank you.

cmirza avatar Mar 22 '23 02:03 cmirza

replacing that line of code worked for me viniciusgomes , thank you

WRyan78 avatar May 17 '23 20:05 WRyan78

If you've installed screenFetch via Homebrew, you can go ahead and get the fix with --HEAD:

brew install --HEAD screenfetch

cglong avatar May 24 '23 07:05 cglong