Jan Klass

Results 113 comments of Jan Klass

PR #59 implements a stronger PW mechanism with PHP 5.5s native methods.

Last time I tried, ZeroC did not provide recent Ice packages for recent PHP versions for Ubuntu Server LTS. As a result, I was unable to test and make it...

Tried/Started setting up a test environment with docker in the branch https://github.com/Kissaki/MumPI/tree/docker-testenv No conclusion/result yet

Hey, sorry, I'm not at home, so I can't check for sure, but you're probably also using a newer version of the ice php extension, which probably has different usage...

If you argue and document removal of no longer supported versions in the MR, removing them is not a problem, it will be appreciated. Yes, I can and will merge...

Hey, in your `settings.inc.php` what [theme](https://github.com/Kissaki/MumPI/blob/c24110434afe6de142534a4496ffa8b9deb3787d/settings.inc.default.php#L23) do you have configured? If it can't find the template files in the corresponding theme folder [it throws this error](https://github.com/Kissaki/MumPI/blob/c24110434afe6de142534a4496ffa8b9deb3787d/classes/TemplateManager.php#L16). For theme `'default'` it...

```$ theme = 'default';``` Is that missing a PHP variable `$` dollar sign? The one you posted indicates console, right?

Next I would try setting debug to true `$debug = true;` in the settings file. This should make PHP report/log all (errorreporting E_ALL). Then check your webserver/php log for errors...

There seem to be some formatting issues in general. In general formatting should be consistent with the code around it. In githubs diff view here you can clearly see indentation...

Went through it. Seems good. Thanks for providing this PR! :) Did not test it yet runtime-wise - just checked the code.