Ask-Permission icon indicating copy to clipboard operation
Ask-Permission copied to clipboard

Published 20 hours ago • verified publisher icon Kishanjvaghela

Source code spelling: Rational when you mean Rationale

Open nyanpasu64 opened this issue 7 years ago • 1 comments

While reading the source code around https://github.com/Kishanjvaghela/Ask-Permission/blob/0b8874b33a75cdacb85a831fcf274f6eaa3df735/askpermission/src/main/java/com/kishan/askpermission/AskPermissionImp.java#L52 to understand your behavior around PackageManager.PERMISSION_GRANTED, I noticed that you misspell "rationale" as "rational", mainly in the term "showRationalDialog". These words have different meanings.

This word was confusing for me, as I thought "RationalDialog" meant "logical dialog" (well, I had no clue what was a logical dialog) instead of "reasons for requesting".

nyanpasu64 avatar Sep 15 '18 12:09 nyanpasu64

unfortunately renaming @Override onShowRationalDialog will change the API.

nyanpasu64 avatar Sep 15 '18 12:09 nyanpasu64