Kirill Osenkov

My take is that this unbounded cache is fine, given 46 items for Orchard. I can't imagine a build with a large number of unique glob expressions in XML.

@SydneyhSmith would it be possible to proritize this? I'm from Azure Data and we have very significant support costs in our org related to modules being in OneDrive. I can...

Given that whoever is calling ILRepack probably has a good facility to delete files, I'm inclined to not provide this functionality.

https://github.com/dotnet/sdk/tree/main/src/Compatibility/ApiCompat

I don't have the foggiest idea what could be causing an AV here: https://github.com/KirillOsenkov/MSBuildStructuredLog/blob/ba0729bd2a130eab7edcacaf00ac3be724a07abd/src/StructuredLogger/BinaryLogger/BuildEventArgsReader.Viewer.cs#L28 Looks like a .NET runtime bug honestly, since it's very rare and intermittent. Reading a binlog...

If possible, try to capture a dump of the process state when this happens. You can use this registry setting and for every crashed process a dump will appear in...

I forgot that I opened the bug initially. Well, I suppose I'll remember to grab a dump next time I see this.

The exact crash is in the Add method: https://github.com/KirillOsenkov/MSBuildStructuredLog/blob/ba0729bd2a130eab7edcacaf00ac3be724a07abd/src/StructuredLogger/BinaryLogger/BuildEventArgsReader.Viewer.cs#L35

This simple change: ```csharp private ConcurrentDictionary regexCache = new(StringComparer.Ordinal); internal void GetFileSpecInfoWithRegexObject( string filespec, out Regex regexFileMatch, out bool needsRecursion, out bool isLegalFileSpec) { var result = regexCache.GetOrAdd(filespec, spec =>...

it creates a regex for every metadata for every globbed file, resulting in >20,000 identical regexes in our relatively simple build.