Kirill Kouzoubov
Kirill Kouzoubov
@luigidifraia this is my main problem with EO format it confuses everyone into thinking that extent is supposed to contain the four corners of the dataset but in Lon/Lat. And...
With the current state of the prepare script and querying code I'm surprised you didn't see more brokenness than you report. We already established that metadata is not recorded correctly...
This is where (2) is broken: https://github.com/opendatacube/datacube-core/blob/183257f1be39c87f6d0157cae29f2f855f07a8cf/datacube/api/query.py#L114-L123 Code above needs to be moved out into a testable function and should handle `lon=180` crossing case in a robust fashion that does...
Steps (3) and (4) are broken here: https://github.com/opendatacube/datacube-core/blob/183257f1be39c87f6d0157cae29f2f855f07a8cf/datacube/api/core.py#L676-L682 Specifically `dataset.extent.to_crs(query_crs)` produces wrong result when `query_crs` is geographic and `dataset.extent` crosses `lon=180`.
there was some progress on this, see referenced commits. Lon/lat bounds are now computed properly, but I believe steps (3) and (4) are still broken.
@kieranricardo can you please provide a sample of your dataset and product yamls? What is most likely happening is that your dataset yaml has measurements defined as a list, while...
@kieranricardo changing data in place is a bit of a sore point in datacube, not really well supported. The DB layer basically assumes append only operations or "approximately append only"....
I can't say I fully comprehend where the boundary between safe and unsafe changes lie for product definition and for dataset documents. I also suspect that the boundary depends on...
@kieranricardo by the way you should be using just `datetime: ...` and not `odc:processing_datetime: ...` to specify timestamp, the later is for "dataset generation time", but what you really need...
@kieranricardo you doing right thing with respect to lineage. The code should be smarter when dealing with EO3 though. You need to use ` datacube dataset add --no-verify-lineage ...` when...