Kipper icon indicating copy to clipboard operation
Kipper copied to clipboard

[Other] Deprecate `--abort-on-first-error` in favor of `--no-recover` as maintainence for the flag is not worth it

Open Luna-Klatzer opened this issue 1 year ago • 0 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current State & Issue

Currently when wanting to run a compilation or execute a program without waiting for everything to be completed, the flag --abort-on-first-error or --no-recover can be specified. Both though have practically the same functionality and therefore don't change much for the user.

The current problem with --abort-on-first-error stems from the underlying compiler configuration CompileConfig.abortOnFirstError, which is directly bound to the flag of the CLI. This causes the compiler to throw an actual KipperError instance, which has to be accounted for in the CLI implementation.

As that introduces multiple edge cases it seems to make a lot more sense to entirely remove it in favor of --no-recover, as that also provides a clear distinction between recovering from errors and attempting to get all possible errors i.e. --recover and instantly aborting on the first error encountered i.e. --no-recover.

Note

With the next release 0.10.4 that fixes #491, --abort-on-first-error will be deprecated and marked for removal in 0.11.0.

Luna-Klatzer avatar Aug 15 '23 11:08 Luna-Klatzer