Kinyugo comments

Results 25 comments of


                                            Kinyugo

Slow Performance of `tokenize_midi_dataset` Function

Thanks for the quick response. In a typical sequence modelling scenario wouldn't it make sense to have overlapping sequences. Or what's your recommended approach?

Slow Performance of `tokenize_midi_dataset` Function

Not necessarily an N-1 overlap but just a way to control the overlap between the sequences. I reckon this would help the model learn continuation better. Also do you pass...

Slow Performance of `tokenize_midi_dataset` Function

That will be awesome. Do you have an idea about how you will go about adding the markers, such that when someone is using a custom dataset/dataloader they can replicate...

Slow Performance of `tokenize_midi_dataset` Function

Could you link the exact lines for how they are detected? FYI I have verified that the fix for the IndexError works. Thanks for fixing that.

Slow Performance of `tokenize_midi_dataset` Function

That's a nice way to implement it. You should consider adding it somewhere in the docs/tutorials that's easier to access. Thanks for the updates. I can't test them atm but...