kinto icon indicating copy to clipboard operation
kinto copied to clipboard

Published 20 hours ago • verified publisher icon Kinto

Type definitions

Open Cnidarias opened this issue 6 years ago • 3 comments

Hi,

so since I started working on the project very recently I found it a little difficult to follow the flow of the code at times and I think this could largely be alleviated if we included type definitions (at least for the function definitions), that way we should still remain compatible with python3.5 but it makes it a little easier.

We could of course at the same time switch over to f-Strings as mentioned in #1659 and lose support for python 3.5 but also include type definitions for non function parameters

What are your thoughts?

Cnidarias avatar Oct 03 '18 07:10 Cnidarias

Yes, I would be in favor of adding type definitions! Don't hesitate to start, even if we don't do everything we keep track here of what's remaining to cover :)

leplatrem avatar Oct 03 '18 11:10 leplatrem

Okay great!

I will work on it shortly, the aim is to stay compatible with 3.5 for now right?

Cnidarias avatar Oct 04 '18 06:10 Cnidarias

I will work on it shortly, the aim is to stay compatible with 3.5 for now right?

Yes, mainly because it is a common python version on several distributions

leplatrem avatar Oct 04 '18 08:10 leplatrem