Velaptor icon indicating copy to clipboard operation
Velaptor copied to clipboard

🚧Refactor unit test assertions

Open kselena opened this issue 3 years ago • 13 comments

Complete The Item Below

  • [X] I have updated the title without removing the 🚧 emoji.

Description

Refactor all of the unit test assertions to use the FluentAssertions library. This will greatly cleanup the unit testing side of things and make the creation of unit tests easier.

Note

  1. We have been migrating all of our assertion code for the past 6 months from standard XUnit assertions API to FluentAssertions API API. Most of the code base has been converted and examples can be found all of the place. Please don't hesitate to ask questions and for help if needed.
  2. Please follow our Contribution Guide

Acceptance Criteria

  • [ ] Latest version of FluentAssertions Nuget package added to the project
  • [ ] Refactor the files below:
    • [x] ~EnsureThatTests.cs~ - 55 lines
    • [ ] SystemDisplayTests.cs - 359 lines
    • [ ] InvalidInputExceptionTests.cs - 50 lines
    • [ ] NoKeyboardExceptionTests.cs - 50 lines
    • [ ] NoMouseExceptionTests.cs - 50 lines

ToDo Items

  • [x] Change type labels added to this issue. Refer to the Change Type Labels section below.
  • [x] Priority label added to this issue. Refer to the Priority Type Labels section below.
  • [x] Issue linked to the correct project (if required).
  • [ ] Issue linked to the correct milestone (if required).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
Workflow Changes workflow
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct.

kselena avatar Sep 08 '22 11:09 kselena

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 16 '22 13:11 stale[bot]

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 19 '23 02:02 stale[bot]

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 22 '23 08:04 stale[bot]

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 09 '23 03:07 stale[bot]

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 07 '23 17:09 stale[bot]

I wish to take up this issue if it's still current.

ljdarj avatar Oct 30 '23 00:10 ljdarj

Do not bother with refactoring the EnsureThatTests file. This file is being removed in another issue.

CalvinWilkinson avatar Oct 30 '23 09:10 CalvinWilkinson

Hello @ljdarj!!

I just wanted to touch base with you and see if you still plan on working with this issue. I noticed that no pull request has been created for this and it seems like there has not been any activity for about 3 weeks.

Thanks for any updates. 😀

CalvinWilkinson avatar Nov 20 '23 14:11 CalvinWilkinson

Just a quick side note @ljdarj.

If you do still plan on doing this, that is completely fine. I just needed to know which release to slot this in for. We can release it at a later time.

CalvinWilkinson avatar Dec 21 '23 10:12 CalvinWilkinson

Sorry I wasn't here, life got in the way. I intend to do it by the first week of January at the latest.

ljdarj avatar Dec 22 '23 21:12 ljdarj

Sorry I wasn't here, life got in the way. I intend to do it by the first week of January at the latest.

Not a problem at all. 😀 I understand how life can get in the way. Especially as we approach the end of the year and the holidays. I will just move the issue to another release.

Thanks for updating me!!

CalvinWilkinson avatar Dec 24 '23 10:12 CalvinWilkinson

@ljdarj Happy New Year!! I hope you're doing well. I am following up on this issue. If you're not able to work on it, that's completely understandable. Please let myself or @CalvinWilkinson know and we can take care of it. Thanks and have a great rest of your week!

kselena avatar Jan 22 '24 14:01 kselena

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 22 '24 19:03 stale[bot]

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 22 '24 18:05 stale[bot]

This stale issue has been closed due to a lack of activity.

stale[bot] avatar May 29 '24 23:05 stale[bot]