ModernWpf icon indicating copy to clipboard operation
ModernWpf copied to clipboard

Add resource for TextBox border tickness when pointer is over

Open mgnslndh opened this issue 3 years ago • 3 comments

Would you accept a PR that adds a resource TextControlBorderThicknessPointerOver that is applied to the BorderThickness when the trigger IsMouseOver is true? The default value would be the same as TextControlBorderThemeThickness but it would allow a theme to override the thickness without restyling the control template.

mgnslndh avatar Dec 15 '20 07:12 mgnslndh

If the same behaviour is applicable in WinUI, the author would accept the PR.

ShankarBUS avatar Dec 15 '20 08:12 ShankarBUS

I guess it could be applicable to WinUI but it is not present in the current WinUI style for the TextBox.

https://github.com/microsoft/microsoft-ui-xaml/blob/31ca62bb0e37b088f09b7953cf5958d2af3fa718/dev/CommonStyles/TextBox_themeresources.xaml#L212-L229

What do you mean by applicable? Does it need to be supported by WinUI first in order for ModernWpf to support it?

mgnslndh avatar Dec 15 '20 10:12 mgnslndh

Does it need to be supported by WinUI first in order for ModernWpf to support it?

This is usually the case, since this library tries to match WinUI closely. There are exceptions due to platform differences, but for a XAML resource like this one, WinUI will need to add it first.

Kinnara avatar Jan 04 '21 15:01 Kinnara