Wenlu Wang

Results 42 comments of Wenlu Wang

> I'm a bit concerned that strings like .trimStart("* ") would be confusing to developers. @jamiebuilds Me too. But there's some reality here: - lodash.{trim, trimStart, trimEnd} -> trim with...

By some shallow search: `intext:"lodash.trim(" site:github.com ext:ts` and `intext:"_.trim(" site:github.com ext:ts` (`lodash.trim` in TypeScript files. JavaScript files do not work with google). I have found: - https://github.com/feathersjs-ecosystem/feathers-vuex/blob/master/src/utils.ts#L46 - https://github.com/contentful/contentful-migration/blob/master/src/bin/cli.ts#L53 -...

Well. I'm not pretty sure the correct way. Friendly ping @orta. Would you mind give some suggestions?

兹磁啊 不过等写多点再tdd吧

https://github.com/zuozijian3720/24game author @zuozijian3720

> It's very helpful to me!

Thanks! It's yet another interesting point. Let's check what does prior art do: - lodash: ![image](https://user-images.githubusercontent.com/6831019/125385147-8dfe0300-e3cc-11eb-9c36-c3916ea9fcf2.png) - python: ![image](https://user-images.githubusercontent.com/6831019/125385180-98b89800-e3cc-11eb-8531-7cc19ca2c219.png) - go: ![image](https://user-images.githubusercontent.com/6831019/125385194-9fdfa600-e3cc-11eb-8f3c-ce9495bf4e42.png) - C#: Not accept string so It's not...

> why not follow string padding and take a trim string Personally, I'm ok with that. It is more intuitive. And honestly, I would think so when I saw this....

Another point about Unicode that I suppose is: `code point is not equals as combining character`. Which means we have to correctly support code point (eg: single emoji). But about...

Okay I agreed. I realized that seems there's nothing handled about code unit/code point/grapheme in string's built-in methods before. (Unfortunately) So, we should not care about them here too. So,...