Matthew Davidson

Results 220 comments of Matthew Davidson

@arnaudgeiser I think your new approach is sound. There's no perfect option, so let's just do the best we can, document it, and let the user decide what to do...

I agree with almost all of this. Netty 5 introduces quite a bunch of changes, and I agree that new names would be warranted. Also, Loom virtual threads kind of...

Any news on this? I ran into the exact same issue, getting errors when I used some Oh My Zsh options that exist in the nixos zsh config, but not...

Probably need to do something like rename the bindings based on static single assignment. It should be simpler, since there's no need for φ functions, since there's no branching in...

Certainly! We're all big fans of clj-kondo, though it's not the friendliest towards macro-heavy code. A few things to keep in mind: 1. For _private_ fns, you don't have to...

Well, sort of. As Zach mentions, it's a quirk of how `description` reports on a BufferedStream, though it could definitely be changed to make more sense. The first thing to...

There's a bit of a race condition here, though. Behind the scenes, multiple threads are being used, so it's completely possible for the description of b to be printed out...

@figurantpp Hmm, I left a [comment](https://github.com/clj-commons/manifold/pull/220#pullrequestreview-1313162532) on your PR saying "Closes #179", but it didn't work. I must be missing something, but based on https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword, it seems like it should...

@ferdinand-beyer At a bare minimum, we should improve the docs, since someone asks this question at least twice a year. Would you be willing to contribute a PR improving them?...