pykan icon indicating copy to clipboard operation
pykan copied to clipboard

methods default lr unless specified

Open kamil2oster opened this issue 7 months ago • 0 comments

The argument for the init method is lr=1 which is okay for LBFGS. However, Adam won't function well with such high lr. lr=1 is the default learning rate in LBFGS itself (while Adam's lr = 0.001). Instead, the argument in init is lr=None and extra lines in the code to change the lr if it's actually provided. It doesn't change the flow but ensures that Adam will work correctly if the user forgets to change the lr.

kamil2oster avatar Jul 15 '24 09:07 kamil2oster