owning-ref-rs icon indicating copy to clipboard operation
owning-ref-rs copied to clipboard

Still maintained?

Open smessmer opened this issue 3 years ago • 5 comments
trafficstars

Is this still maintained? I see PRs with fixes going back to 2017 but nothing seems to get merged.

smessmer avatar Mar 08 '22 06:03 smessmer

Hi @Kimundi @avitex @NikVolf

Would you be interested on handing over maintenance over or commit to fixing some soundness issues ?

The crate has ~ 12 M downloads as of today and it would be nice to fix these and keep it maintained

We are thinking of raising advisories here https://github.com/rustsec/advisory-db/issues/1174

The unsoundness has been documented here https://github.com/noamtashma/owning-ref-unsoundness

Soudness Issues https://github.com/Kimundi/owning-ref-rs/issues/49 https://github.com/Kimundi/owning-ref-rs/issues/61 https://github.com/Kimundi/owning-ref-rs/issues/71 https://github.com/Kimundi/owning-ref-rs/issues/77

pinkforest avatar Jul 30 '22 20:07 pinkforest

I created a repository that fixes some soundness issues. https://github.com/utilForever/owning-ref-rs

utilForever avatar Aug 05 '22 07:08 utilForever

That would be really really useful considering how recurring this pattern is. Currently I refrain from using it because of the footguns implied by the unsoundness, but that would otherwise become a must!

Ten0 avatar Aug 14 '22 21:08 Ten0

I created a repository that fixes some soundness issues. https://github.com/utilForever/owning-ref-rs

With the history being entirely rewritten it's unclear what unsoundness issues are fixed/to what extent these differ from the open PRs.

Ten0 avatar Aug 14 '22 21:08 Ten0

prometheus-client addressed this by using parking_lot here: https://github.com/prometheus/client_rust/pull/78

pinkforest avatar Aug 14 '22 21:08 pinkforest