validates_hostname

validates_hostname copied to clipboard

Allow a config to update ALLOWED_TLDS

1

Rather than updating the constant, and then waiting for a release, would it make sense to have a config option for gem users to configure the `ALLOWED_TLDS` ? I guess...

kuahyeow

feature: Change to a Rails 4 ActiveModel validator.

3

Rails 4 introduced ActiveModel, ActiveModel::Validations and ActiveModel::EachValidator. Instead of injecting ourselves into ActiveRecord::Base, we will be automatically picked up. This fixes #10. We can now also be used on ActiveModel...

schwern

Calling ActiveRecord::Base.send(:include, PAK::ValidatesHostname) has side effects

6

I was wondering why Rails.application.config.active_record.belongs_to_required_by_default was not working and this gem is the culprit. I am wondering whether there is a fix for this.

pgouv

When reading through the docs, I noticed a typo in the example. This PR addresses this.

gerardo-navarro