zstd-rs icon indicating copy to clipboard operation
zstd-rs copied to clipboard

Shouldn't MatchGeneratorDriver be public?

Open morrisonlevi opened this issue 7 months ago • 1 comments

I'm trying to write a streaming encoder, and since this type is not public, I'm struggling to embed it into my struct and such, since I cannot name this type.

morrisonlevi avatar May 19 '25 18:05 morrisonlevi

Oh right! I think I will add a type alias that allows naming the "default" FrameEncoder. I don't think I want to expose the MatchGeneratorDriver. Having that type linked that explicitly to the new function probably was a mistake to begin with.

KillingSpark avatar May 20 '25 08:05 KillingSpark

I just encountered this issue as well when I was trying to use it with the tar crate.

theoparis avatar Nov 02 '25 07:11 theoparis

Thanks for the bump! I just published version 0.8.2 with a public MatchGeneratorDriver in ruzstd::encoding this should allow you to name it as the M in FrameCompressor<R,W,M>

KillingSpark avatar Nov 02 '25 11:11 KillingSpark

I'm gonna close this issue, if the fix didn't work for some reason please feel free to reopen :)

KillingSpark avatar Nov 04 '25 09:11 KillingSpark