RW_FacialStuff icon indicating copy to clipboard operation
RW_FacialStuff copied to clipboard

Critical issue with ADS and other prosthetic mods

Open N0B0DY-1MP0R7AN7 opened this issue 5 years ago • 5 comments

I'm getting

Facial Stuff: No texture for added part: Things/Pawn/Humanlike/AddedParts/Eye_TacticalCorneaImplant_Right_Narrow - Graphic_Multi_AddedHeadParts

this error all the time.

But the bigger issue is this here:

Exception spawning loaded thing Cat460383: System.NullReferenceException: Object reference not set to an instance of an object
at FacialStuff.PawnExtensions.CheckFaceForAddedParts (Verse.Hediff,FacialStuff.CompFace,Verse.BodyPartRecord,Verse.BodyPartRecord,Verse.BodyPartRecord) <0x00020>
at FacialStuff.PawnExtensions.CheckPart (System.Collections.Generic.List`1<Verse.BodyPartRecord>,Verse.Hediff,FacialStuff.CompFace,FacialStuff.CompBodyAnimator,bool) <0x00580>
at FacialStuff.PawnExtensions.CheckForAddedOrMissingParts (Verse.Pawn) <0x0053d>
at FacialStuff.CompBodyAnimator.PostSpawnSetup (bool) <0x00166>
at Verse.ThingWithComps.SpawnSetup (Verse.Map,bool) <0x0007f>
at (wrapper dynamic-method) Verse.Pawn.SpawnSetup_Patch1 (object,Verse.Map,bool) <0x00219>
at (wrapper dynamic-method) Verse.GenSpawn.Spawn_Patch0 (Verse.Thing,Verse.IntVec3,Verse.Map,Verse.Rot4,Verse.WipeMode,bool) <0x00b2b>
at Verse.Map.FinalizeLoading () <0x004a9>

This completely breaks my cat with a prosthetic leg. Whatever the cause is, Ticking the cat thereafter is impossible because of a null reference exception and it becomes dead in the water. Trying to do anything with it breaks the entire GUI completely because the main renderer messes up.

Here's the full log: https://gist.github.com/HugsLibRecordKeeper/2dc6e3858b6e3804ce14149d4e66dfd3

N0B0DY-1MP0R7AN7 avatar Dec 23 '18 00:12 N0B0DY-1MP0R7AN7

Update: Contrary to all expectations Facial stuff definitely is involved. Disabling the mod fixes the issue even on the previously broken save. This is weird since the issue went deeper than graphical rendering, with the thinker and thus the job finding of an animal being broken (meanwhile facial stuff i thought was only handling rendering and humans if you disable animal parts) Either way somehow Facial Stuff was responsible for the core thinker process of the cat pawn breaking when it got a replacement limb.

N0B0DY-1MP0R7AN7 avatar Dec 23 '18 00:12 N0B0DY-1MP0R7AN7

I have contacted the author of ADS and apparently the problem is not on their part. This means that Facial Stuff somehow breaks the renderer of animals when a prosthetic is present, even when animal limb rendering is disabled. So much so, that the pawn loading can't be completed leaving the pawn without a thinker, unable to act in any way producing an error every tick. And when one does force some animation and a pawn reset by killing and revival the entire rendering process even for the GUI breaks down.

I don't know how this happened but this is pretty major and awful.

N0B0DY-1MP0R7AN7 avatar Dec 23 '18 04:12 N0B0DY-1MP0R7AN7

Okay, so i tried to move the mod to the end of the load order to see if that did anything but it didnt. So i moved it back to where it was, right before the animal mods. And while there are still lots of errors showing up with facial stuff and that cat, apparently at least now it's able to function. So this might be a workaround for anyone else? I dunno.

N0B0DY-1MP0R7AN7 avatar Dec 24 '18 08:12 N0B0DY-1MP0R7AN7

And it ceased functioning again. Please someone help me track this down because this is maddening.

N0B0DY-1MP0R7AN7 avatar Dec 30 '18 14:12 N0B0DY-1MP0R7AN7

Might be fixed

Killface1980 avatar Jan 09 '19 22:01 Killface1980