Kilian Valkhof

Results 187 comments of Kilian Valkhof

> The [session 'extension-loaded' event](https://www.electronjs.org/docs/latest/api/session#event-extension-loaded) should be emitted whenever an extension is loaded into the session. This will be emitted when an extension is installed. @samuelmaddock / other readers: this...

This turns `allowFlip` on and off which works to "rejig" the popup (Thanks!) but I'd be worried that it could also have unintended consequences for when `allowFlip` is needed (or...

I've updated the repository above to toggle flag at an 8ms interval while the accordion animation plays and it works _okay_. That's workable for me, but it's still something I...

Looking at the file I can also see that while it updates when the keyboard opens and closes, it still updates related to the full window dimensions (?) which don't...

Ok, so the issue is that when the bounds get returned: - height is the inner height (excluding the top frame, same as doing `document.documentElement.getBoundingClientRect()`) - x is the position...

Ok so this is a known issue: https://github.com/electron/electron/issues/3183 @samuelmaddock would you be willing to make `POSITION_PADDING` configurable so I can adapt it depending on the platform?

@samuelmaddock the difference between getBounds() and getContentBounds() is 0 on linux, so this issue is not solved. (I previously mentioned this here: https://github.com/samuelmaddock/electron-browser-shell/issues/121#issuecomment-2703431398 )