uno-zen icon indicating copy to clipboard operation
uno-zen copied to clipboard

Make flexible add more icons

Open waja opened this issue 8 years ago • 12 comments

Looking into recent history of Foundation Icons it seems the development has stopped: https://github.com/zurb/foundation-icons/commits/master

Font Awesome seems to be well maintained and has a much of the recent 'brands' included: http://fontawesome.io

related: http://ionicons.com http://typicons.com https://mfglabs.github.io/mfglabs-iconset

customize: https://icomoon.io http://www.flaticon.com

waja avatar Dec 17 '15 13:12 waja

I don't think that this is a thing that we need (and less urgently).

Currently we get a set of commons icons. When an icon make a rebranding then is moment to think to update, but definitely this works and I'm happy to don't update code that is not broken :-)

Kikobeats avatar Dec 21 '15 12:12 Kikobeats

The motivation of this was, that I miss some of the social networks used in the recent days.

waja avatar Dec 21 '15 15:12 waja

@waja for example? maybe is my fault because I just use twitter :P

Kikobeats avatar Dec 21 '15 15:12 Kikobeats

For example: mixcloud, soundcloud, slack and xing. Just to name a few.

waja avatar Dec 21 '15 15:12 waja

:+1:

I added in your comment more links. I want to make this theme unique, so better have options :)

what do you like more? I like ionicons!

Kikobeats avatar Dec 21 '15 16:12 Kikobeats

I've looked into them and mfglabs-iconset looks (beside fontawsome) with most social media icons. Xing (for example) is only available there. I've suggested fortawesome, cause it looks like it has the most complete support of social icons.

waja avatar Dec 21 '15 19:12 waja

@waja ok, go ahead.

Do you think that you can conver this issue into a PR? Steps:

  1. Replace foundation reference for fontawesome.
  2. Map the same icon to the same css class fonts.
  3. Add a set of common icons missing currently.

Kikobeats avatar Dec 21 '15 21:12 Kikobeats

As I'm not very familiar with HTML/CSS/JS I can't promise anything or that it will fit you quality standards. I'll have a look into it but ... you know. :-)

waja avatar Dec 22 '15 07:12 waja

@Kikobeats Looked into the available icons at font-awesome. Do you think it makes sense to ship the foundation-icons AND font-awesome to not break existing customized installations?

waja avatar Dec 22 '15 08:12 waja

@waja absolutely. We have to map the new icons to the same css class for backward compatibility and add the missing icons

Kikobeats avatar Dec 22 '15 09:12 Kikobeats

omg, fast click :o

Kikobeats avatar Dec 22 '15 09:12 Kikobeats

@Kikobeats Hmm ... to be honest I guess that's way above my skills in web frontend development. At least to share the outcome with others.

waja avatar Dec 22 '15 09:12 waja