SIMNumberSetter icon indicating copy to clipboard operation
SIMNumberSetter copied to clipboard

Correct error when SIM card is missing

Open whitipet opened this issue 2 years ago • 1 comments

If the seven card is not inserted in the phone, it shows the error "Failed to connect to the Xposed service, make sure the module is enabled and you have rebooted", but this is not a correct error, confusing. I tried to flash some old phones and install xposed in different ways, but I kept getting this error. But when I just inserted the SIM card, everything worked. Judging by this code, only the presence of the number is checked, and when it is missing, the general xposed error is displayed. I suggest adding an additional check for the presence of a SIM card.

whitipet avatar Mar 04 '22 14:03 whitipet

You're right in that the Xposed error is displayed when it shouldn't be, I'm aware of that I just need to get around to fixing it. There's no need for a SIM presence check though, as I can simply differentiate between runWithService returning null and the exception (the former is Xposed failing, the latter is an incompatible card)

KieronQuinn avatar Mar 04 '22 14:03 KieronQuinn