pyquaternion icon indicating copy to clipboard operation
pyquaternion copied to clipboard

add eulers angles

Open mgoacolou opened this issue 5 years ago • 5 comments

add method to retreive euler angle with convention as parameter

mgoacolou avatar Jun 14 '19 14:06 mgoacolou

Thanks for the PR @mgoacolou

After taking a look, I like what you're doing. Is there a reason you've used the matrix form as an intermediate representation? I'd rather not have to go through the extra conversion step if possible as it compounds any errors in the conversions or bugs in the code.

After a quick google, it seems there may be some resources for converting directly between quaternion form and Euler angles see https://math.stackexchange.com/a/693368 Unfortunately, this only defines operations for the z-x-z and z-y-x conventions.

My preference would be to implement at least those two conventions via direct conversion from quaternion form and leave it open to being extended for additional conventions via future PRs

KieranWynn avatar Nov 10 '19 07:11 KieranWynn

Do you plan to merge this into master anytime soon? Or, is there another way to convert from quaternions to Euler angles?

fabrizioschiano avatar Sep 15 '20 10:09 fabrizioschiano

Is this PR ready to go, just waiting to be rolled into the 1.0 release?

mikepianka avatar Nov 15 '21 23:11 mikepianka

Any updates on this? Would love euler angle support.

davidfufu avatar Aug 19 '22 19:08 davidfufu

Any updates there? Why this PR can't merge 4 years?

warenick avatar Sep 13 '23 08:09 warenick