DeepDanbooru icon indicating copy to clipboard operation
DeepDanbooru copied to clipboard

Minor update to project.load_project

Open AdamantLife opened this issue 4 years ago • 1 comments

Issue and Resolution

deepdanbooru.project.load_project still loads tags using dd.data.load_tags_from_project; as far as I can tell this should simply be updated to load_tags_from_project now that the function has been moved to the project module (other parts of the code were updated to dd.project.load_tags_from_project, so I'm assuming I'm not missing anything).

Background

I was experimenting with the library and was using commands.evaluate_project as a template for writing an evaluation function. My code raised an error on dd.project.load_project(project_path) referencing the noted bug. I applied the mentioned fix and no longer receive the error.

Additional Comments

I've made the change on my fork and can open a Pull Request for the change if that's easier for you.

AdamantLife avatar Jun 20 '20 02:06 AdamantLife

I agree that current API is quite incomplete now. I'll improve/rewrite all of APIs in the next version. (no ETA yet)

KichangKim avatar Jun 25 '20 07:06 KichangKim