[ACHIEVEMENT] Meep Meep

[ZimGil]

Added the "Meep Meep" achievement

• New Achievement: "Meep Meep" [resolves #191]

  Will grant an achievement to the author of the first comment within 5 minutes of the Pull Request creation. Will work with either comment and inline comments, but not both - only the first

[ghost]

There were the following issues with this Pull Request

• Commit: f918e20096955cf73c88d61f6390d9577c3dc72d
  • ✖ message may not be empty
  • ✖ type may not be empty
• Commit: 7df3e9c976d9f6b53ebcd6fab5c260d895cd173a
  • ✖ message may not be empty
  • ✖ type may not be empty
• Commit: 539f5edb7535f86494b67982cbdf45ac333b2d1d
  • ✖ message may not be empty
  • ✖ type may not be empty
• Commit: d58800f67a2d80371309b2deb2fd682830449ac0
  • ✖ message may not be empty
  • ✖ type may not be empty
• Commit: 10173d6b87be1a34296bb886207afa6264435ff2
  • ✖ message may not be empty
  • ✖ type may not be empty
• Commit: d55f0c5714aa34525badace49872bfbbc1d667fa
  • ✖ message may not be empty
  • ✖ type may not be empty
• Commit: c7aa7ce6904bf90fca873b4f5662de6b9f3f2a41
  • ✖ message may not be empty
  • ✖ type may not be empty
• Commit: 76fd0615c72c0bbd5332886b66093384644f71d4
  • ✖ message may not be empty
  • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

---

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

[coveralls]

Coverage remained the same at 100.0% when pulling 76fd0615c72c0bbd5332886b66093384644f71d4 on ZimGil:develop into 16aa68387db9b2016ca36933d3cd5c326955ebe6 on Kibibit:develop.

[ZimGil]

This is actually require changes. The Achievement should not be granted to the pull request creator, even if he made comments in time.

• [ ] Prevent pull request creator from achieving
• [ ] Make appropriate tests

[ortichon]

@ZimGil @Thatkookooguy We should address the issue of bots/hound. do their comments count as comments? if so, we should filter them out. and actually, update this achievement for each new bot we add?

[thatkookooguy]

@ZimGil @Thatkookooguy We should address the issue of bots/hound. do their comments count as comments? if so, we should filter them out. and actually, update this achievement for each new bot we add?

I'm not sure if we mind bots getting achievements. Just like the greenkeeper bot can get achievements. We don't discriminate bots lol

I'm trying to think if 5 minutes is not too long for just a "first comment" and not a "first review comment". review comments should take time, but regular comments are easy to add and can easily be shorter than 5 minutes

[ortichon]

I don't have a problem with bots getting achievements too, but then @ZimGil will have to change his logic. IIRC the current logic gives the achievement to the first (under 5 minutes) commenter. I guess we'll have to change to logic to give the achievement to ALL under 5 minutes commenters?

[thatkookooguy]

I don't have a problem with bots getting achievements too, but then @ZimGil will have to change his logic. IIRC the current logic gives the achievement to the first (under 5 minutes) commenter. I guess we'll have to change to logic to give the achievement to ALL under 5 minutes commenters?

I think it should just be shorter. Most bots write a comment based on something that happened.

If the PR format or commit format is wrong, or for a first PR (the welcome bot), the comment will be fast. But for lint errors, tests, coverage, etc., bot comments should be "not as fast".

So we need to test this a bit I guess but it sounds to me like in ver2, the bots that will get the achievements are the welcome-bot, and commitlint-bot. All the other bots won't run fast enough.

Base on what @ZimGil wants, I think we should do one of the two:

• make this achievement only for "review comments". That's basically a human domain, so if we want to isolate this to humans, that makes sense. Also, a review is hard to do under 5 minutes unless the PR is very small. So I think that makes sense

• shorten the 5 minutes to something more challenging. writing a normal comment takes nothing. 5 minutes sounds a bit slow IMO for a Road Runner reference :-) for normal comments I'll go for something like 1-2 minutes? what do you guys think?

so basically, that depends on what we, and especially @ZimGil , thinks will be more fun\funny when getting this achievement

[thatkookooguy]

We should maybe test this on a repo with bots installed and see if everything works as expected

[ZimGil]

Base on what @ZimGil wants, I think we should do one of the two:

• make this achievement only for "review comments". That's basically a human domain, so if we want to isolate this to humans, that makes sense. Also, a review is hard to do under 5 minutes unless the PR is very small. So I think that makes sense
• shorten the 5 minutes to something more challenging. writing a normal comment takes nothing. 5 minutes sounds a bit slow IMO for a Road Runner reference :-) for normal comments I'll go for something like 1-2 minutes? what do you guys think?

so basically, that depends on what we, and especially @ZimGil , thinks will be more fun\funny when getting this achievement

I actually think both case fit the reference and are funny. With that said, I do think review comments are more eligible for this achievement.