kicad-symbols icon indicating copy to clipboard operation
kicad-symbols copied to clipboard

Published 20 hours ago • verified publisher icon KiCad

Added TPA3126D2

Open LJJS opened this issue 6 years ago • 12 comments

Added the TPA3126D2 from Texas Instruments.

tpa3126d2

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • [x] Provide a URL to a datasheet for the symbol(s) you are contributing http://www.ti.com/lit/ds/symlink/tpa3126d2.pdf
  • [x] An example screenshot image is very helpful
  • [ ] Ensure that the associated footprints match the official footprint library
  • [x] If there are matching footprint PRs, provide link(s) as appropriate https://github.com/KiCad/kicad-footprints/pull/947
  • [x] Check the output of the Travis automated check scripts - fix any errors as required

LJJS avatar Sep 04 '18 02:09 LJJS

Thanks for your comments. I updated the files and created a PR for the footprint https://github.com/KiCad/kicad-footprints/pull/947.

LJJS avatar Sep 17 '18 16:09 LJJS

Here are a couple from me:

  • FAULTZ should be Open Collector type (we don't have open drain).
  • I think I'd bunch the audio inputs at the top, then put all the logic pins (1-3, 12-16), and finally GVDD above pins 6 and 8 for easiest layout and connection to power/ground.
  • Since the right side really only needs 4 caps placed closely before the outputs could fan out to the inductors, it may be possible to shrink the symbol vertically once the left-side pins are re-arranged.
  • Is there a situation where PVCC isn't all the same voltage? If not, and I don't see it, stack 4 pins.
  • Perhaps AVCC should be left of PVCC since that may connect to the left-side pins.

@DanSGiesbrecht Good review. Thanks!

evanshultz avatar Sep 17 '18 16:09 evanshultz

Thanks for your reviews!

@evanshultz I changed the symbol so it match your ideas.

LJJS avatar Sep 17 '18 16:09 LJJS

Thanks! Looks good!

Sorry that I missed this earlier, but the ref des should be top left and keep the PN on top right.

It seems most logical to put Left Positive on top (both sides), then L-, R+, and finally R-. And perhaps give a space between the LIN and RIN pins so they are clearly separately. But I'll merge it as is if you're happy with it.

I'll look at the footprint today.

@DanSGiesbrecht Do you have any more comments?

evanshultz avatar Sep 17 '18 18:09 evanshultz

I changed the ref des position.

I think the pin position is better how it is now, so the symbol is kept nice symmetrical.

LJJS avatar Sep 17 '18 19:09 LJJS

@evanshultz no I don't - looks good to me! Thanks for checking.

DanSGiesbrecht avatar Sep 17 '18 19:09 DanSGiesbrecht

Alright. Then once the footprint is merged, if Travis is all green, this can be merged. Thanks all!

evanshultz avatar Sep 17 '18 20:09 evanshultz

@LJJS I just noticed this symbol was committed to Audio.lib. It should be in Amplifier_Audio.lib.

evanshultz avatar Sep 17 '18 21:09 evanshultz

@LJJS I just noticed this symbol was committed to Audio.lib. It should be in Amplifier_Audio.lib.

Done

LJJS avatar Sep 18 '18 12:09 LJJS

Hi @LJJS

So pending your footprint PR getting updated, everything else looks good! The footprint filter and field will need updating, but otherwise I'm satisfied with this! I'll keep an eye out for the footprint resolution.

DanSGiesbrecht avatar Sep 29 '18 17:09 DanSGiesbrecht

Added the pending KLC issue label to keep track of the issues that somehow have a dependency on a KLC issue.

antoniovazquezblanco avatar Oct 29 '18 12:10 antoniovazquezblanco

Footprint is Abandoned

myfreescalewebpage avatar Sep 22 '20 08:09 myfreescalewebpage