kicad-symbols icon indicating copy to clipboard operation
kicad-symbols copied to clipboard

Add Ai-Thinker ESP32-CAM

Open stefanct opened this issue 4 years ago • 5 comments

  • Schematic: http://wiki.ai-thinker.com/_media/esp32_cam%E5%BC%80%E5%8F%91%E6%9D%BF%E5%8E%9F%E7%90%86%E5%9B%BE.pdf
  • Footprint's PR: https://github.com/KiCad/kicad-footprints/pull/2289

ESP32-CAM

It's not completely centered to minimize size while keeping pins on 100mils. The logic pins are separated into left and right as follows: The pins on the left side are probably best left alone in most applications as they are required for programming the module (UART), accessing the PSRAM, and for generating the clock signal of the camera. The ones on the right are less restricted. They would be used to access the µSD card.

The power options are somewhat peculiar too. There is an LDO between 5V and 3V3 that can be bypassed to supply 3.3V directly via the respective pin. Additionally there is a third power pin named VCC that is connected via a solder bridge to either of those. IRC suggested to set +5V as power input but leave the other two to passive. However, the CI check demands VCC to be an explicit power pin:

Power pins should be of type POWER INPUT or POWER OUTPUT
 - Pin VCC (13) @ (-300,600) is of type PASSIVE

Is that OK or do you prefer something different? Before I asked on IRC I was going to set VCC as power input and the other two as power output.

Finally, I am unsure about the pin numbering. The schematic uses the two pin connectors named P1 and P2 for the interface. I don't know how this should be correctly mapped to the single continuous pin numbering of the kicad symbol/footprint. The hardware has P1.8 (3V3) and P2.8 (5V) with a square pad. Since all of this does not make any sense at all I have converted this to match other modules, i.e., DIP pin numbering. Thus 1=P2.8 (5V), 2=P2.7 (GND), ... 8=P2.1, 9=P1.1 (GND), ... 16=P2.8 (3V3).

stefanct avatar May 16 '20 19:05 stefanct

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 16 '20 19:05 CLAassistant

Hi @stefanct , thanks for contributing,

A few comments I have during my review:

  • [ ] This link seems better for the datasheet: "http://wiki.ai-thinker.com/media/esp32/docs/esp32-cam%E4%BA%A7%E5%93%81%E8%A7%84%E6%A0%BC%E4%B9%A6.pdf"
  • [ ] Please use the pin numbering of the link above (last page of the pdf, change the footprint PR too)
  • [ ] 3V3 should be Power Output
  • [ ] Pin length should be 100mil for this symbol
  • [ ] You can arrange the symbol with positive power pins centered and all IO on the right as done for several ESP32 device in the lib

Cheers, Joel

myfreescalewebpage avatar Sep 05 '20 13:09 myfreescalewebpage

@stefanct ping, are you still working on this ?

myfreescalewebpage avatar Sep 21 '20 08:09 myfreescalewebpage

@myfreescalewebpage it took you 4 months for the review so I deem this ping after two weeks a bit offensive TBH. That being said, I am currently not working on it and can't predict when I'll have time and motivation again to do it. I would not mind if anybody else finishes it instead.

stefanct avatar Sep 21 '20 08:09 stefanct

@stefanct sorry it's not the goal to be offensive. Just want to remember reviewers are all volunteers and 4 months to get the beginning of the review is not exceptional regardless to the amont of pull requests. On the other side we are preparing kicad v6 and for this all the repositories will be migrated to GitLab. We try to integrate the maximum of pull request we can before end of September, reason of this ping.

I indicate the PR is Abandoned right now, but anybody can continue if required.

myfreescalewebpage avatar Sep 21 '20 19:09 myfreescalewebpage