kicad-symbols
kicad-symbols copied to clipboard
Added mikroBUS socket symbol
Added mikroBUS socket symbol according to datasheet (http://download.mikroe.com/documents/standards/mikrobus/mikrobus-standard-specification-v200.pdf).
I didn't put GND pins to the bottom of the symbol because of original shape. I left all of the pins as Passive because this is just a connector, not a full device.
Footprint pull request: https://github.com/KiCad/kicad-footprints/pull/1519.
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
- [x] Provide a URL to a datasheet for the symbol(s) you are contributing
- [x] An example screenshot image is very helpful
- [x] Ensure that the associated footprints match the official footprint library
- A new fitting footprint must be submitted if the library does not yet contain one.
- [ ] Check the output of the Travis automated check scripts - fix any errors as required
- [ ] Give a reason behind any intentional library convention rule violation.
Hello @ppielorz thanks for contributing,
I have not made a complete review, but the following points should be fixed for the moment:
- [x] Pin should be grouped by function, not according to their physical position
- [x] +3.3V at the top, GND stacked at the bottom
- [x] Pin type should be specified
Cheers, Joel
Hi Joel, Should I group these pins even though it's a connector?
Paweł
Yes exactly, that's a KiCad policy.
@ppielorz thanks, doing a full review right now:
- [ ] ~~I think the symbol can be called simply
mikroBUS
isn't ?~~ - [x] Graphic style of SCL and SCK should be Line
- [x] You should group TX with RX to simplify the schematics, this break the rule of input on the left and output on the right but it's not a problem. All pins should be group by fucntion. For example serial port is a function, spi port is a function etc.
- [x] RST in bottom will be better to wire it
- [x] You should stack GND pins
- [x] You can have the symbol more symmetrical. Example below.
Joel
@myfreescalewebpage Referring to your remarks:
- [ ] I think the symbol can be called simply
mikroBUS
isn't ?
Well, in mikroBus datasheet there is a clear division between socket and addon board. Personally I would leave it but I can follow your advice if you wish.
- [ ] Graphic style of SCL and SCK should be Line
Done
- [ ] You should group TX with RX to simplify the schematics, this break the rule of input on the left and output on the right but it's not a problem. All pins should be group by fucntion. For example serial port is a function, spi port is a function etc.
Done. I changed a bit your proposition to get more linear pin number order but they are grouped.
- [ ] RST in bottom will be better to wire it
Done.
- [ ] You should stack GND pins
Done
- [ ] You can have the symbol more symmetrical. Example below.
Done
New screenshot below:
@ppielorz thanks for the fixes.
Well, in mikroBus datasheet there is a clear division between socket and addon board.
Ok, in this case keep like that. Can you simply change "socket" to "Socket" for consistency with the footprint name
Also, I just realized the footprint filter is not correct, you should correct to "mikroBUS*"
Cheers, Joel
Done.
@ppielorz thanks, just made a final review, notice a final bug here reported in travis: GND pins are not properly stacked. The rule is: first pin Power Input visible, other pin Passive invisible. To solve the issue on your symbol, can you set pin 16 Passive ? Thanks!
Thanks, just need to wait for the footprint now :)
Closing/opening to refresh the CLA.
No news of the author on the footprint, indicate this is Abandoned