kicad-symbols icon indicating copy to clipboard operation
kicad-symbols copied to clipboard

Added mikroBUS socket symbol

Open ppielorz opened this issue 5 years ago • 12 comments

Added mikroBUS socket symbol according to datasheet (http://download.mikroe.com/documents/standards/mikrobus/mikrobus-standard-specification-v200.pdf).

I didn't put GND pins to the bottom of the symbol because of original shape. I left all of the pins as Passive because this is just a connector, not a full device.

Footprint pull request: https://github.com/KiCad/kicad-footprints/pull/1519.

image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • [x] Provide a URL to a datasheet for the symbol(s) you are contributing
  • [x] An example screenshot image is very helpful
  • [x] Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • [ ] Check the output of the Travis automated check scripts - fix any errors as required
  • [ ] Give a reason behind any intentional library convention rule violation.

ppielorz avatar Apr 03 '19 16:04 ppielorz

Hello @ppielorz thanks for contributing,

I have not made a complete review, but the following points should be fixed for the moment:

  • [x] Pin should be grouped by function, not according to their physical position
  • [x] +3.3V at the top, GND stacked at the bottom
  • [x] Pin type should be specified

Cheers, Joel

myfreescalewebpage avatar Apr 03 '19 16:04 myfreescalewebpage

Hi Joel, Should I group these pins even though it's a connector?

Paweł

ppielorz avatar Apr 03 '19 16:04 ppielorz

Yes exactly, that's a KiCad policy.

myfreescalewebpage avatar Apr 03 '19 17:04 myfreescalewebpage

@ppielorz thanks, doing a full review right now:

  • [ ] ~~I think the symbol can be called simply mikroBUS isn't ?~~
  • [x] Graphic style of SCL and SCK should be Line
  • [x] You should group TX with RX to simplify the schematics, this break the rule of input on the left and output on the right but it's not a problem. All pins should be group by fucntion. For example serial port is a function, spi port is a function etc.
  • [x] RST in bottom will be better to wire it
  • [x] You should stack GND pins
  • [x] You can have the symbol more symmetrical. Example below.

Capture

Joel

myfreescalewebpage avatar Apr 04 '19 18:04 myfreescalewebpage

@myfreescalewebpage Referring to your remarks:

  • [ ] I think the symbol can be called simply mikroBUS isn't ?

Well, in mikroBus datasheet there is a clear division between socket and addon board. Personally I would leave it but I can follow your advice if you wish.

  • [ ] Graphic style of SCL and SCK should be Line

Done

  • [ ] You should group TX with RX to simplify the schematics, this break the rule of input on the left and output on the right but it's not a problem. All pins should be group by fucntion. For example serial port is a function, spi port is a function etc.

Done. I changed a bit your proposition to get more linear pin number order but they are grouped.

  • [ ] RST in bottom will be better to wire it

Done.

  • [ ] You should stack GND pins

Done

  • [ ] You can have the symbol more symmetrical. Example below.

Done

New screenshot below: image

ppielorz avatar Apr 04 '19 19:04 ppielorz

@ppielorz thanks for the fixes.

Well, in mikroBus datasheet there is a clear division between socket and addon board.

Ok, in this case keep like that. Can you simply change "socket" to "Socket" for consistency with the footprint name

Also, I just realized the footprint filter is not correct, you should correct to "mikroBUS*"

Cheers, Joel

myfreescalewebpage avatar Apr 05 '19 16:04 myfreescalewebpage

Done.

ppielorz avatar Apr 07 '19 07:04 ppielorz

@ppielorz thanks, just made a final review, notice a final bug here reported in travis: GND pins are not properly stacked. The rule is: first pin Power Input visible, other pin Passive invisible. To solve the issue on your symbol, can you set pin 16 Passive ? Thanks!

myfreescalewebpage avatar Apr 07 '19 07:04 myfreescalewebpage

Thanks, just need to wait for the footprint now :)

myfreescalewebpage avatar Apr 07 '19 09:04 myfreescalewebpage

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 11 '19 18:07 CLAassistant

Closing/opening to refresh the CLA.

myfreescalewebpage avatar Jul 11 '19 19:07 myfreescalewebpage

No news of the author on the footprint, indicate this is Abandoned

myfreescalewebpage avatar Sep 30 '20 10:09 myfreescalewebpage