kicad-library-utils icon indicating copy to clipboard operation
kicad-library-utils copied to clipboard
verified publisher icon KiCad

Check symbol for duplicate graphic elements (#37)

Open cpresser opened this issue 6 years ago • 5 comments

Introduce new rule S3.9 to check if the symbol has duplicate graphical elements.

This implements the 'SIMPLE' approach mentioned here: See https://github.com/KiCad/kicad-library-utils/issues/37

So far there is no 'written' Rule for KLC yet. If there is some positive feedback for this patch, I can create a PR for that as well.

cpresser avatar Jun 01 '19 16:06 cpresser

see https://github.com/KiCad/kicad-symbols/pull/2267

ghost avatar Nov 06 '19 09:11 ghost

The new rule S3.9 would need to be added to the website. Please open a pull request over at the website repo (still on github as far as i know) and link between the two

poeschlr avatar Feb 23 '20 17:02 poeschlr

Here is the PR for the website: https://github.com/KiCad/kicad-website/pull/475

cpresser avatar Feb 24 '20 14:02 cpresser

Thanks for the review, those were all valid points with really help full recommendations. :+1: And sorry for the huge delay - this PR somehow slipped my attention.

cpresser avatar Sep 05 '20 12:09 cpresser

The Website-Merge-Request now lives here: https://gitlab.com/kicad/services/kicad-website/-/merge_requests/475

cpresser avatar Sep 05 '20 12:09 cpresser