kicad-footprints icon indicating copy to clipboard operation
kicad-footprints copied to clipboard

Published 20 hours ago • verified publisher icon KiCad

Add the TI DRL0006A footprint for TPD4E1B06DRL

Open Doeme opened this issue 4 years ago • 8 comments

Refer to The Process here: https://github.com/KiCad/kicad-symbols/pull/2256

http://www.ti.com/lit/ds/symlink/tpd4e1b06.pdf

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • [x] Provide a URL to a datasheet for the footprint(s) you are contributing
  • [x] An example screenshot image is very helpful
  • [x] If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • [x] Check the output of the Travis automated check scripts - fix any errors as required
  • [x] Give a reason behind any intentional library convention rule violation.

Doeme avatar Sep 23 '20 20:09 Doeme

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 23 '20 20:09 CLAassistant

i dont know what the ci is whining about, can anybody explain? There is a %R Test on the f.fab layer.

Doeme avatar Sep 23 '20 20:09 Doeme

@Doeme thanks to submit this footprint. Two comments to start the review:

  • [ ] It's impossible to open the footprint with kicad, I have an error while opening
  • [ ] Reference on the F.Fab layer should be %R (see travis error)
  • [ ] The 3D path definition is missing in the file (to be added even if it does not exist yet)

For this simple footprint I expect travis with no error no warning. I suggest to copy SOT footprint and modify the dimensions, it will be easier !

Joel

myfreescalewebpage avatar Sep 24 '20 08:09 myfreescalewebpage

I think this has been created with a v5.99 nightly build, telling by the tstamp attributes and such.

@doeme please use v5.1 for now

chschlue avatar Sep 24 '20 08:09 chschlue

@Doeme ping

myfreescalewebpage avatar Sep 29 '20 14:09 myfreescalewebpage

@myfreescalewebpage pong, I was on holiday, with very limited internet access, and generally a no touchy-touchy rule for the laptop (the Alps were gorgeous :)

I'll recompile kicad tomorrow. Hopefully this will also help to please the CI, since I did add this %R text it's complaining about.

Doeme avatar Sep 30 '20 21:09 Doeme

@Doeme no problem of course. I know the Alps are gorgeous, I born in the Alps :) I keep PR ongoing, but on your side please use delivered version available for download at https://kicad-pcb.org/download/ to create footprint

myfreescalewebpage avatar Sep 30 '20 21:09 myfreescalewebpage

okay, downgrading to v5.1 seems to have fixed the CI.

Doeme avatar Oct 01 '20 21:10 Doeme