kicad-footprints icon indicating copy to clipboard operation
kicad-footprints copied to clipboard

Added ARJM11D7-114-AB-EW2 footprint

Open Misaka0x2730 opened this issue 4 years ago • 7 comments

Added ARJM11D7-114-AB-EW2 - Single port 100Base-T connector with PoE. https://abracon.com/Magnetics/ARJM11.pdf image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • [x] Provide a URL to a datasheet for the footprint(s) you are contributing
  • [x] An example screenshot image is very helpful
  • [ ] If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • [ ] Check the output of the Travis automated check scripts - fix any errors as required
  • [ ] Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

Misaka0x2730 avatar Jun 21 '20 09:06 Misaka0x2730

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 21 '20 09:06 CLAassistant

Hi and thanks for you contribution.

I added a few screenshots here for reference. (EDIT Changed the first screenshot to be of variant C/D) image image image

I took a look and found a few issues:

  • [ ] The name should not contain AB. The footprint will also work with different LED arrangements
  • [ ] The name should include _Horizontal
  • [ ] TBD: Please use pin-numbers for the LEDs instead of L1.. that will make it consistent with other parts in the library.
  • [ ] The arrow on silkscreen and the Chevron on F.Fab are on the top left. But Pin1 is on the right side. That does not match.
  • [ ] The pin numbers seem to be okay, but please rotate the part so that pin1 is in the top left quadrant (https://kicad-pcb.org/libraries/klc/F4.2/) RJ45_Wuerth_7499010121A_Horizontal is a good example for that.
  • [ ] The courtyard clearance should be 0.5mm. Measuring from F.Fab and Pin11 (clearance to the copper)
  • [ ] The Body-Dimensions should be 21.3x15.9mm
  • [ ] I did not yet check the exact location of pins. Please fix the above issues first and re-check your drawing. Then I will give the geometry a full review.

Open questions, can you please help @chschlue

  • Should Pin11 be named SH. It is a shield per KLC S3.7, but also electrically connected via some caps. I would argue yes, it is called SHIELD in the datasheet.
  • The LED pins are called L1... and so on in the datasheet. But it is inconsistent with all other parts currently in the lib. For which kind of consistency should we go? I am good with either one.

cpresser avatar Sep 08 '20 20:09 cpresser

@cpresser Hello, thank you for comments! But your picture show A & B mechanical options, this footprint for C & D as on picture below: image

Misaka0x2730 avatar Sep 08 '20 21:09 Misaka0x2730

@cpresser Hello, thank you for comments! But your picture show A & B mechanical options, this footprint for C & D as on picture below:

You are right. Sorry about that. I exchanged the first screenshot.

cpresser avatar Sep 08 '20 21:09 cpresser

Should Pin11 be named SH. It is a shield per KLC S3.7, but also electrically connected via some caps. I would argue yes, it is called SHIELD in the datasheet.

LGTM

The LED pins are called L1... and so on in the datasheet. But it is inconsistent with all other parts currently in the lib. For which kind of consistency should we go? I am good with either one.

I'm for prefixes. That way it doesn't get too messy if something like RJ45_Amphenol_RJHSE5380-08 with LEDs is added. Perhaps we should even use A1/K1 and so on, although there are connectors with multi-color LEDs as well.

chschlue avatar Sep 09 '20 03:09 chschlue

@Misaka0x2730 what is the status here ? Thanks

myfreescalewebpage avatar Sep 22 '20 17:09 myfreescalewebpage

@Misaka0x2730 ping ?

myfreescalewebpage avatar Sep 29 '20 14:09 myfreescalewebpage