kicad-footprints icon indicating copy to clipboard operation
kicad-footprints copied to clipboard

Add Texas_R-PWSON-N8_EP0.4x1.2mm.kicad_mod

Open fh-nbt opened this issue 4 years ago • 7 comments

[Please be patient, it's my first ever pull request]

Added Texas_R-PWSON-N8_EP0.4x1.2mm.kicad_mod based on the similar Texas_R-PWSON-N12_EP0.4x2mm.kicad_mod. So far no 3d model because I'm figuring out the best way to do this.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • [ ] Provide a URL to a datasheet for the footprint(s) you are contributing
  • [ ] An example screenshot image is very helpful
  • [ ] If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • [ ] Check the output of the Travis automated check scripts - fix any errors as required
  • [ ] Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!) Texas_R-PWSON-N8_EP0 4x1 2mm kicad_mod tpd3f303.pdf

fh-nbt avatar Mar 24 '20 12:03 fh-nbt

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 24 '20 12:03 CLAassistant

Hi @fh-nbt, Thanks for you first contribution.

Unfortunately I have to ask you to redo it. This is a footprint that can be auto-generated using https://github.com/pointhi/kicad-footprint-generator. We do this since we trust the generator to produce the correct footprint. Reviewing the .yaml file is rather easy. So please open a PR on the footprint-generator with the changes to the .yaml file. Update this PR to include only the new .kicad_mod spit out by the generator.

The datasheet for the body-dimensions is here: https://www.ti.com/lit/pdf/MPSS018 (found via https://www.ti.com/packaging/docs/searchtipackages.tsp?packageName=SON) looking for DQD

There is already a similar footprint in the file you can use as reference: Texas_S-PWSON-N8_EP1.2x2mm as defined in scripts/Packages/Package_NoLead__DFN_QFN_LGA_SON/size_definitions/wson.yaml.

cpresser avatar Mar 24 '20 14:03 cpresser

So far no 3d model because I'm figuring out the best way to do this.

We still include a filename for the 3D-Model. If somebody decides to generate a 3D-Model the footprint does not need to be changed.

cpresser avatar Mar 24 '20 14:03 cpresser

@cpresser thank you for the nice explanation. I assume, pending acceptance of this pull request, I shall add a pull request for the appended script as it will be the first of its kind footprint (TI R-PWSON) in there.

fh-nbt avatar Mar 24 '20 17:03 fh-nbt

@cpresser thank you for the nice explanation. I assume, pending acceptance of this pull request, I shall add a pull request for the appended script as it will be the first of its kind footprint (TI R-PWSON) in there.

Its actually the other way around. Please open a PR for the changes (additions) in the .yaml file. Link that that new PR to this one. Then the .yaml change will get reviewed and merged. Once that is good, I will merge this PR here.

cpresser avatar Mar 24 '20 18:03 cpresser

relates to https://github.com/pointhi/kicad-footprint-generator/pull/517

fh-nbt avatar Mar 26 '20 10:03 fh-nbt

HI, I am very sorry this took so long. I took a look at the generator-PR. Technically it is good, just some formatting needs fixing. Please push the result of the generator to this PR. Then I will merge both,

cpresser avatar Sep 17 '20 18:09 cpresser