kicad-footprints icon indicating copy to clipboard operation
kicad-footprints copied to clipboard

Published 20 hours ago • verified publisher icon KiCad

Added Bourns 3362P potentiometer

Open gggfred opened this issue 5 years ago • 3 comments

Added Bourns 3362P vertical potentiometer Datasheet imagen

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • [x] Provide a URL to a datasheet for the footprint(s) you are contributing
  • [x] An example screenshot image is very helpful
  • [x] If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • [x] Check the output of the Travis automated check scripts - fix any errors as required
  • [x] Give a reason behind any intentional library convention rule violation.

gggfred avatar Sep 18 '19 21:09 gggfred

It's my first thoughts about your contribution.

Unless it's a bug in my FreeCAD, most of dimensions don't conform with KLC or even match those found in datasheet.

  • [ ] Courtyard clearance must be 0.25mm, as per KLC F5.3 (http://kicad-pcb.org/libraries/klc/F5.3/); image image

  • [ ] For rounded rectangle pads the corner size should be 25% with a maximum radius of 0.25mm, as per KLC F7.3 (http://kicad-pcb.org/libraries/klc/F7.3/); image

  • [ ] It would be better if the Fab elements were closed. image

  • [ ] Distance between pad-1 and Silk is 0.19mm. Clearance between silkscreen and exposed copper elements is recommended to be 0.2mm, as per KLC 5.1 (http://kicad-pcb.org/libraries/klc/F5.1/);

  • [ ] Just my personal preference, but not required. I prefer the following orientation. image

  • [ ] I'm not sure, but I think that Fab elements shouldn't overlapping other features of the same layer. @poeschlr, can you give me a hint about this? image

  • Footprint name, OK

  • 3D model path, OK

  • Pads: minimum drilled hole diameter -> 0.69mm (current 0.8mm); minimum annular ring width -> 0.15mm (current 0.32mm), OK

  • Fab, Silk and CrtYd line thickness, OK

  • Fabrication attributes, OK

  • Description, OK

  • Datasheet link, OK

  • Extra RefDes on Fab, OK

gmsotavio avatar Sep 21 '19 02:09 gmsotavio

I have already changed the footprint by taking your suggestions, thanks for your comments, please check again and say if there are problems

gggfred avatar Sep 21 '19 19:09 gggfred

@gggfred I try to continue the review from this point:

  • [ ] Silkscreen distance with pad should be at least 0.2mm. You should interrupt the lines when the silkscreen is too much closer to the pad. See for example "Potentiometer_Bourns_3266Z_Horizontal" in the lib
  • [ ] Distance from F.Fab to F.CrtYd to be set to 0.25mm

Joel

myfreescalewebpage avatar Sep 20 '20 10:09 myfreescalewebpage