glslang icon indicating copy to clipboard operation
glslang copied to clipboard

Emit `OpModfStruct` for GLSL `EOpModf` instead of `OpModf`

Open chyyran opened this issue 1 year ago • 5 comments

My attempt at fixing https://github.com/KhronosGroup/glslang/issues/3756.

Also updated the tests to account for the new type getting added.

chyyran avatar Oct 07 '24 21:10 chyyran

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 07 '24 21:10 CLAassistant

Seems like more tests need to be updated. I ran glslangtests with --update-mode but it seems more needs to be done?

chyyran avatar Oct 08 '24 20:10 chyyran

Managed to get the runtests tests to run and updated those results as well.

chyyran avatar Oct 08 '24 22:10 chyyran

@arcady-lunarg any updates on getting this merged?

chyyran avatar Oct 14 '24 20:10 chyyran

@arcady-lunarg addressed nits as of 5c784d6

chyyran avatar Oct 21 '24 23:10 chyyran