glslang icon indicating copy to clipboard operation
glslang copied to clipboard

Published 20 hours ago • verified publisher icon KhronosGroup

Support constant expression calculated by matrixCompMult.

Open jimihem opened this issue 1 year ago • 3 comments

glslang report error for "const mat2 cval = matrixCompMult(mat2(1.0), mat2(1.0));". Spec says: The value returned by certain built-in function calls whose arguments are all constant expressions is also constant expressions.

jimihem avatar Dec 27 '23 02:12 jimihem

@ncesario-lunarg Please review this PR.

jimihem avatar Feb 01 '24 02:02 jimihem

@arcady-lunarg Please help review this PR.

jimihem avatar Apr 26 '24 01:04 jimihem

Actually, have you seen the discussion in #925? From reading it, it sounds like matrixCompMult is not supposed to be constant-folded.

arcady-lunarg avatar Jun 19 '24 19:06 arcady-lunarg

@arcady-lunarg glslcompiler in mesa support matrixCompMult constant fold. I have made some modifications based on your feedback.

jimihem avatar Jul 15 '24 04:07 jimihem

I've rebased your branch, as soon as it clears CI I will do a squash and merge.

arcady-lunarg avatar Jul 15 '24 17:07 arcady-lunarg