glslang icon indicating copy to clipboard operation
glslang copied to clipboard

No #line directives generated when --target-env is vulkan1.1, vulkan1.2 or vulkan1.3

Open TonyBarbour opened this issue 1 year ago • 3 comments

GPU-AV depends on #line directives to determine which source line is responsible for a validation error. glslang is generating #line directive(s) with --target-env vulkan1.0, but not vulkan1.1, 1.2, or 1.3. #line is also created when no --target-env is specified. Issue is at https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/5596

TonyBarbour avatar Apr 18 '23 22:04 TonyBarbour

We have the same problem in LightweightVK when using glslang C-interface. No SPIR-V OpSource is generated when emit_nonsemantic_shader_debug_source is enabled.

https://github.com/corporateshark/lightweightvk/blob/d1c511d9bfaf8e96c0efa00a33b7bec5d1cd7e79/lvk/vulkan/VulkanUtils.cpp#L649

corporateshark avatar Nov 26 '23 00:11 corporateshark

@corporateshark I think that is a somewhat different issue, could you open a new issue for your problem? Also, could you confirm that you're using the most recent version of glslang as there was a somewhat similar sounding bug that was fixed recently.

arcady-lunarg avatar Nov 27 '23 17:11 arcady-lunarg