glTF-Validator icon indicating copy to clipboard operation
glTF-Validator copied to clipboard

feat: add only issues option (opposite of ignoredIssues)

Open Apidcloud opened this issue 2 years ago • 4 comments

This PR makes it possible to provide a list of the only errors we want to validate (opposite of ignoredIssues). In my case I only want to check for 'ACCESSOR_INVALID_FLOAT', so this is easier than providing every other error using ignoredIssues.

Why? Our users often download broken models from the internet, and yet most 3d model viewers are sensible to some of the errors and can still load them. We also run them through Draco compression, and some of the errors end up not having a visible effect. But because of this issue with NaN in Draco (https://github.com/google/draco/issues/998), we want to avoid the bus error (and thus the hanging). Ideally, it is something that will be handled by Draco itself in the future; But until then, the glTF-Validator is the best tool to check and avoid such specific error.

Apidcloud avatar Apr 28 '23 09:04 Apidcloud

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 28 '23 09:04 CLAassistant

Any estimate on when this might be released?

Apidcloud avatar May 23 '23 14:05 Apidcloud

I have the same issue when will this be released?

t3h32eKK avatar Mar 04 '24 11:03 t3h32eKK

@lexaknyazev is there any chance that this will be merged soon?

t3h32eKK avatar Mar 15 '24 12:03 t3h32eKK