Vulkan-ValidationLayers icon indicating copy to clipboard operation
Vulkan-ValidationLayers copied to clipboard

VK_EXT_descriptor_buffer: missing GPU-AV VUIDs

Open jeremyg-lunarg opened this issue 3 years ago • 6 comments
trafficstars

These are the VUIDs not implemented in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/4828

Valid Usage IDs requested

  • [ ] VUID-VkDescriptorGetInfoEXT-type-08028
  • [ ] VUID-vkCmdBindDescriptorBuffersEXT-pBindingInfos-08053
  • [ ] VUID-vkCmdBindDescriptorBuffersEXT-pBindingInfos-08054
  • [ ] VUID-vkCmdDraw-None-08116
  • [ ] VUID-vkCmdDraw-None-08119
  • [ ] VUID-vkCmdSetDescriptorBufferOffsetsEXT-pOffsets-08126
  • [ ] VUID-vkCmdSetDescriptorBufferOffsetsEXT-pOffsets-08127

Additional Context Any additional information:

jeremyg-lunarg avatar Nov 18 '22 16:11 jeremyg-lunarg

@stu-s and @archimedus please let me know if there are more or corrections are needed. I'll check against the tracking info you provided offline as well.

jeremyg-lunarg avatar Nov 18 '22 16:11 jeremyg-lunarg

Some of these are related to RTX VUIDs listed in https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/3792

jeremyg-lunarg avatar Nov 18 '22 16:11 jeremyg-lunarg

Please take a look at the spreadsheet for the current status. When I checked the list was:

08016 08017 08028 08029 08053 08054 08058 08073 08077 08081 08085 08089 08116 08119 08126 08127

@archimedus should be updating it as any last VUIDs/tests are added

stu-s avatar Nov 24 '22 13:11 stu-s

Thanks. I've updated the description to match your list, which mostly matches the output of vk_validation_stats.py. There's some additional oddities that are worth documenting.

  • VUID-VkAccelerationStructureCaptureDescriptorDataInfoEXT-accelerationStructure-08093 is implemented as VUID-VkAccelerationStructureCaptureDescriptorDataInfoEXT-accelerationStructureNV-08093
  • VUID-vkGetDescriptorEXT-dataSize-08125 is implemented as VUID-vkGetDescriptorEXT-pDescriptorInfo-08125

I will fix these after the PR merges, which should happen very shortly.

The following VUIDs are listed as missing, because they are superseded by new VUIDs when descriptor buffers are enabled:

  • VUID-VkDescriptorSetLayoutBinding-descriptorType-02210
  • VUID-vkCmdDrawMeshTasksEXT-None-02699
  • VUID-vkCmdDrawMeshTasksIndirectCountEXT-None-02699
  • VUID-vkCmdDrawMeshTasksIndirectEXT-None-02699

IMO documenting these here is sufficient, but in some cases we've switched which VUID is output depending on the set of enabled extensions.

jeremyg-lunarg avatar Nov 30 '22 16:11 jeremyg-lunarg

I haven't tried the master branch but could it be that VUID-VkDescriptorAddressInfoEXT-range-08940 isn't implemented? I don't see it on the list @jeremyg-lunarg posted, but I didn't get a warning with the latest SDK.

codecnotsupported avatar Jun 17 '23 03:06 codecnotsupported

  1. I cleaned up the list, the remaining things are what is missing and they are all GPU-AV based VUs
  2. @codecnotsupported VUID-VkDescriptorAddressInfoEXT-range-08940 was added at sometime and I see it in the latest SDK

spencer-lunarg avatar Jan 29 '24 01:01 spencer-lunarg