Vulkan-ValidationLayers icon indicating copy to clipboard operation
Vulkan-ValidationLayers copied to clipboard

No GPUAV descriptor valication instrumentation produced for raytracing pipelines created with libraries

Open tiago-rodrigues opened this issue 10 months ago • 1 comments

With the following GPUAV options:

  khronos_validation.gpuav_shader_instrumentation = true
  khronos_validation.gpuav_descriptor_checks = true
  khronos_validation.gpuav_debug_print_instrumentation_info = true

When attempting to enable GPUAV shader instrumentation for descriptor validation with a ray-tracing pipeline created using VK_PIPELINE_CREATE_LIBRARY_BIT_KHR, it appears to take the same code path as GPL in: https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/382d3ac0f6a8b1cc8ff0f8c4d5be9b15a40f29ea/layers/gpuav/instrumentation/gpuav_shader_instrumentor.cpp#L817

When creating a raytracing pipeline with such libraries passed in, no GPUAV instrumentation is apparently being produced.

Is GPUAV shader instrumentation expected to work in this case?

tiago-rodrigues avatar Apr 28 '25 20:04 tiago-rodrigues

Good question, that code is very much was added for Graphics Pipeline Library

Ray tracing libraries should work, but honestly we have zero tests for those in GPU-AV and I think this would be stopping it

@arno-lunarg we should really add a NegativeGpuAVDescriptorIndexing test for normal RTX as well as pipeline library to make sure the shader instrumentation flow is working properly

spencer-lunarg avatar Apr 29 '25 03:04 spencer-lunarg