Vulkan-Tutorial icon indicating copy to clipboard operation
Vulkan-Tutorial copied to clipboard

Fix vector size for presentCompleteSemaphores.

Open asuessenbach opened this issue 1 month ago • 1 comments

Only the semaphores signalled on finished rendering need to be indexed by the image index. All other resources (command buffers, fences, semaphores signalled on present completion) are indexed by the frame index.

Includes some minor clean-up on chapter 15 as well.

As usual, if this is considered to be ok, I can carry this change to all the other chapters.

asuessenbach avatar Nov 05 '25 17:11 asuessenbach

As usual, if this is considered to be ok, I can carry this change to all the other chapters.

Definitively yes.

Without this change, the tutorial is not spec compliant, see #65

SaschaWillems avatar Nov 09 '25 12:11 SaschaWillems

but tutorial text needs to be adjusted to

If you could give me a hint, where the corresponding tutorial text is, I could try to adjust it accordingly.

asuessenbach avatar Nov 26 '25 13:11 asuessenbach

E.g. "03_Frames_in_flight.adoc". Looking at this, it does at least partially differ from the updated code and might need to be updated.

SaschaWillems avatar Nov 26 '25 16:11 SaschaWillems

@SaschaWillems Ok, I've adjusted some documentation. Please have a closer look at it!

asuessenbach avatar Nov 27 '25 17:11 asuessenbach

Anything else I'd need to adjust?

asuessenbach avatar Dec 04 '25 13:12 asuessenbach