Vulkan-Tutorial icon indicating copy to clipboard operation
Vulkan-Tutorial copied to clipboard

Lesson 7 nitpicks

Open TomServeaux opened this issue 5 months ago • 5 comments

This is short.

A reference to a VkImageViewCreateInfo in a paragraph when the code has vk::ImageViewCreateInfo

Sometimes uses imageViewCreateWindow and sometimes uses createInfo, and like before there is mixing of C API idioms and C++ (e.g. VK_IMAGE_ASPECT_COLOR_BIT vs vk::ImageAspectFlagBits::eColor which are both used).

TomServeaux avatar Jul 23 '25 23:07 TomServeaux

Thanks! Please keep these coming! I'll update the PR I have open to capture them as I get time to address them. It might take me a few days as I'm working on the next tutorial right now; but I'll get time soon.

gpx1000 avatar Jul 23 '25 23:07 gpx1000

Okay. Clearly I'm writing them as I go through the tutorial for the first time, the last lesson had a lot of stuff and took my all day (off and on) and who knows how long the rest of the tutorial will take me to get through so there's no rush on my end.

TomServeaux avatar Jul 23 '25 23:07 TomServeaux

I'm very thankful that you're doing this. It's very helpful.

gpx1000 avatar Jul 23 '25 23:07 gpx1000

It helps that I'm unemployed and have the time, haha

Ha....

TomServeaux avatar Jul 23 '25 23:07 TomServeaux

By which I mean I am not trying to rush you to include my suggestions. I am however trying to rush through the tutorial so I can get to rendering stuff.

TomServeaux avatar Jul 24 '25 23:07 TomServeaux