Vulkan-Samples icon indicating copy to clipboard operation
Vulkan-Samples copied to clipboard

Change vkb::HPPGLTFLoader from a facade over vkb::GLTFLoader to a self-contained class using Vulkan-Hpp.

Open asuessenbach opened this issue 2 years ago • 4 comments

Description

Includes

  • slightly improved struct [HPP]Meshlet in [hpp_]api_vulkan_sample.h;
  • additional facade-functions in common/hpp_utils.h;
  • a new function is_image_format_supported in HPPPhysicalDevice, that catches the exception thrown on not supported formats;
  • some minor corrections/improvements in GLTFLoader and scene_graph::Scene
  • adjustments according to the new scene_graph/component classes in HPPVulkanSample and rendering::subpasses::HPPForwardSubpass;
  • new facade classes scene_graph::components::HPPCamera, scene_graph::components::HPPLight, scene_graph::components::HPPMesh, scene_graph::components::HPPPBRMaterial, scene_graph::components::HPPSampler, scene_graph::components::HPPTexture, scene_graph::components::HPPTransform, scene_graph::HPPNode, scene_graph::HPPScene, and scene_graph::scripts::HPPAnimation
  • adjustments in facade classes scene_graph::components::HPPImage and scene_graph::components::HPPSubMesh
  • fully transcoded classes scene_graph::components::HPPPerspectiveCamera and scene_graph::components::image::HPPAstc
  • a fix in gshader_to_mshader.mesh.

Build tested on Win10 with VS2022. All hpp-based samples tested on Win10 with NVidia GPU.

General Checklist:

Please ensure the following points are checked:

  • [x] My code follows the coding style
  • [x] I have reviewed file licenses
  • [x] I have commented any added functions (in line with Doxygen)
  • [x] I have commented any code that could be hard to understand
  • [x] My changes do not add any new compiler warnings
  • [x] My changes do not add any new validation layer errors or warnings
  • [x] I have used existing framework/helper functions where possible
  • [x] My changes do not add any regressions
  • [x] I have tested every sample to ensure everything runs correctly
  • [x] This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • [x] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • [ ] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • [x] I have tested the sample on at least one compliant Vulkan implementation
  • [x] If the sample is vendor-specific, I have tagged it appropriately
  • [x] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • [x] Any dependent assets have been merged and published in downstream modules
  • [ ] For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme
  • [ ] For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • [ ] For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

asuessenbach avatar Dec 11 '23 13:12 asuessenbach

Can we discuss this in the next samples call? The PR itself is fine, but it has a lot of framework changes and I'm unsure how these align with the framework direction we recently talked about.

SaschaWillems avatar Dec 17 '23 16:12 SaschaWillems

Can we discuss this in the next samples call?

Sure, but I can't attend the next call. Will be back again next year.

asuessenbach avatar Dec 17 '23 22:12 asuessenbach

@gary-sweet What compiler are you using? Obviously, the compilers in our CI are less picky. Maybe we should add that compiler to our CI? That said, would you please try again if my latest change resolves those errors?

asuessenbach avatar Jan 09 '24 18:01 asuessenbach

@gary-sweet What compiler are you using? Obviously, the compilers in our CI are less picky. Maybe we should add that compiler to our CI? That said, would you please try again if my latest change resolves those errors?

I'm not sure how but I completely missed your reply somehow. Apologies for that. Sadly the latest changes haven't changed the compile errors.

The compiler is "gcc version 8.3.0 (stbgcc-8.3-1.0) " for aarch64

gary-sweet avatar Jan 26 '24 08:01 gary-sweet

Closed for now, as the C/Cpp unification takes a different path.

asuessenbach avatar May 07 '24 07:05 asuessenbach