Vulkan-Samples icon indicating copy to clipboard operation
Vulkan-Samples copied to clipboard

Add a new sample - subgroups operations

Open Patryk-Jastrzebski-Mobica opened this issue 1 year ago • 15 comments

Description

Please include a summary of the change, new sample or fixed issue. Please also include relevant motivation and context. Please read the contribution guidelines

Fixes #

General Checklist:

Please ensure the following points are checked:

  • [ ] My code follows the coding style
  • [ ] I have reviewed file licenses
  • [ ] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • [ ] I have commented any added functions (in line with Doxygen)
  • [ ] I have commented any code that could be hard to understand
  • [ ] My changes do not add any new compiler warnings
  • [ ] My changes do not add any new validation layer errors or warnings
  • [ ] I have used existing framework/helper functions where possible
  • [ ] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions
  • [ ] My changes do not add any regressions
  • [ ] I have tested every sample to ensure everything runs correctly
  • [ ] This PR describes the scope and expected impact of the changes I am making

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • [ ] I have tested the sample on at least one compliant Vulkan implementation
  • [ ] If the sample is vendor-specific, I have tagged it appropriately
  • [ ] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • [ ] Any dependent assets have been merged and published in downstream modules
  • [ ] For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme

That's a nice little sample! Is it still work in progress, as the title says? Would it be easy to extend that sample by adding a non-subgroups path for comparison?

asuessenbach avatar Jun 29 '23 12:06 asuessenbach

Hi @asuessenbach, Yes, I'm still working on this sample. I'm currently implementing the FFT algorithm. Next week, I plan to push another commit/change with the vertex animation ready. And as for the last question, I cannot answer you yet.

Any update on this? Having a subgroups sample would be very much appreciated :)

SaschaWillems avatar Aug 03 '23 16:08 SaschaWillems

Any updates on this sample? Having a subgroup sample would be a great addition :)

SaschaWillems avatar Nov 19 '23 18:11 SaschaWillems

Hi @SaschaWillems, I apologise for not updating for such a long time. Unfortunately the implementation of the sample is not yet finished. I still have some work left to do:

  • implement BRDF reflections,

  • fixing problems with pipeline barriers - on the Intel Iris Xe the sample runs stable, but on the RTX 2060 it crash after a few seconds,

  • adding a description to the README file.

No need to apologize. Your work is very much appreciated and I'm happy to hear that this sample is coming along :)

SaschaWillems avatar Nov 20 '23 15:11 SaschaWillems

Any update on this?

SaschaWillems avatar Feb 18 '24 15:02 SaschaWillems

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: Krzysztof-Dmitruk-Mobica
:white_check_mark: Patryk-Jastrzebski-Mobica
:x: kdmitruk
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 20 '24 08:03 CLAassistant

Hi @Patryk-Jastrzebski-Mobica, we noticed there's an issue with the CLA on this one - looks like the test got confused with the login alias (kdmitruk). Can you look into this? Not quite sure what the fix is - perhaps sign the CLA again using the alias? Thanks

marty-johnson59 avatar Jul 03 '24 14:07 marty-johnson59

Hi @marty-johnson59, I will to do something about it this week. I hope to find some time in the near future to finish the sample :).