Vulkan-Samples icon indicating copy to clipboard operation
Vulkan-Samples copied to clipboard

Typo in README.md

Open jcortell68 opened this issue 3 years ago • 1 comments

The readme incorrectly has the option "-es" in the Android cmdline, for launching the app to invoke a specific sample.

It should be either -e or --es. -es does not work. The app gets an extras with a key of "s", which will not accomplish anything useful :-)

jcortell68 avatar Sep 15 '22 19:09 jcortell68

Oh...and it's more than that problem. The second argument needs to have two set of quotes if you're going to use --es (or -e) with the key being "cmd". Here's the full cmdline that will work adb shell am start-activity -n com.khronos.vulkan_samples/com.khronos.vulkan_samples.SampleLauncherActivity --es cmd "'sample swapchain_images'"

Alternatively, you could do adb shell am start-activity -n com.khronos.vulkan_samples/com.khronos.vulkan_samples.SampleLauncherActivity --esa cmd sample,swapchain_images

But honestly, both of these are unnecessarily complicated. The most concise way of doing it is adb shell am start-activity -n com.khronos.vulkan_samples/com.khronos.vulkan_samples.SampleLauncherActivity -e sample swapchain_images

jcortell68 avatar Sep 15 '22 19:09 jcortell68

Thanks for bringing this up. We'll change the readme accordingly.

SaschaWillems avatar Oct 09 '22 13:10 SaschaWillems