Vulkan-Samples icon indicating copy to clipboard operation
Vulkan-Samples copied to clipboard

WIP: Shared target libs for faster builds

Open gpx1000 opened this issue 3 years ago • 2 comments

Description

This is an ongoing effort to switch from static to shared libraries with the goal to decrease the memory requirements on linking and also decrease the build time requirements.

Fixes #366

General Checklist:

Please ensure the following points are checked:

  • [ ] My code follows the coding style
  • [ ] I have reviewed file licenses
  • [ ] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • [ ] I have commented any added functions (in line with Doxygen)
  • [ ] I have commented any code that could be hard to understand
  • [ ] My changes do not add any new compiler warnings
  • [ ] My changes do not add any new validation layer errors or warnings
  • [ ] I have used existing framework/helper functions where possible
  • [ ] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions
  • [ ] My changes do not add any regressions
  • [ ] I have tested every sample to ensure everything runs correctly
  • [ ] This PR describes the scope and expected impact of the changes I am making

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • [ ] I have tested the sample on at least one compliant Vulkan implementation
  • [ ] If the sample is vendor-specific, I have tagged it appropriately
  • [ ] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • [ ] Any dependent assets have been merged and published in downstream modules
  • [ ] For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme

gpx1000 avatar Dec 01 '21 02:12 gpx1000

This change helps my build performance massively. A full build after clean previously took 9.5 minutes, and takes only 35 seconds with this change in place.

gary-sweet avatar Jan 17 '22 11:01 gary-sweet

I'd love to do QA on this, but on Windows the build fails due to unresolved externals in the astc third party library. Any way around this? Github CI also fails with that error.

SaschaWillems avatar Jan 17 '22 12:01 SaschaWillems