VK_Video

[gpx1000]

Description

This is a sample showing how to use Vulkan Video. Developer's MUST have FFMPEG development libraries installed. FFMPEG is used for demuxing duties only. This sample attempts to make a generic library out of the NVIDIA Vulkan Video Sample to show how it can be used in a more generic way. As this is a very complex sample, it likely will take many revisions before landing.

NB: Vulkan Video is only supported in desktop environments. Also, it isn't required to ultimately use FFMPEG, one can use things like https://github.com/lieff/minimp4 or similar to handle the demuxing. However; that would only support h264 while FFMPEG is well tested and supports all codecs. Working on a demuxing solution is beyond the scope of this sample; but it is possible to do.

Tested in Linux on NVIDIA hardware.

General Checklist:

Please ensure the following points are checked:

• [ ] My code follows the coding style
• [ ] I have reviewed file licenses
• [ ] I have commented any added functions (in line with Doxygen)
• [ ] I have commented any code that could be hard to understand
• [ ] My changes do not add any new compiler warnings
• [ ] My changes do not add any new validation layer errors or warnings
• [ ] I have used existing framework/helper functions where possible
• [ ] My changes do not add any regressions
• [ ] I have tested every sample to ensure everything runs correctly
• [ ] This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

• [ ] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
• [ ] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

• [ ] I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

• [ ] I have tested the sample on at least one compliant Vulkan implementation
• [ ] If the sample is vendor-specific, I have tagged it appropriately
• [ ] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
• [ ] Any dependent assets have been merged and published in downstream modules
• [ ] For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
• [ ] For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
• [ ] For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

[SaschaWillems]

Haven't had time to do a proper review yet, but it looks like this PR downgrades the asset submodule to a very old version, which would remove several assets used by some of the recent examples.

[SaschaWillems]

Any hint on how to get this to work on windows? When doing the CMake setup, the sample is skipped (not available in Visual Studio) because it can't find ffmpeg (which I have installed manually):

CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.26/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (FFMPEG)
  does not match the name of the calling package (FFmpeg).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  samples/extensions/video/CMake/FindFFmpeg.cmake:191 (find_package_handle_standard_args)
  samples/extensions/video/CMakeLists.txt:20 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

In order to get it working I'd need to set a lot of paths in cmake:

Is there an alternative way? Like only having one ffmpeg path that needs to be set in cmake, and cmake picking up what it need from ffmpeg based on that single path?

The sample does not have a readme, which could help with setting up all the things required for it to work.

[gpx1000]

It should hopefully only need avcodec avcore and avformat. But I do need to update ffmpeg to only need one path

On Sun, Dec 15, 2024, 3:47 AM Sascha Willems @.***> wrote:

Any hint on how to get this to work on windows? When doing the CMake setup, the sample is skipped (not available in Visual Studio) because it can't find ffmpeg (which I have installed manually):

CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.26/Modules/FindPackageHandleStandardArgs.cmake:438 (message): The package name passed to find_package_handle_standard_args (FFMPEG) does not match the name of the calling package (FFmpeg). This can lead to problems in calling code that expects find_package result variables (e.g., _FOUND) to follow a certain pattern. Call Stack (most recent call first): samples/extensions/video/CMake/FindFFmpeg.cmake:191 (find_package_handle_standard_args) samples/extensions/video/CMakeLists.txt:20 (find_package) This warning is for project developers. Use -Wno-dev to suppress it.

In order to get it working I'd need to set a lot of paths in cmake:

image.png (view on web) https://github.com/user-attachments/assets/13c0c1d9-b2f9-4af2-bb98-8fe26bf6e3e5

Is there an alternative way? Like only having one ffmpeg path that needs to be set in cmake, and cmake picking up what it need from ffmpeg based on that single path?

— Reply to this email directly, view it on GitHub https://github.com/KhronosGroup/Vulkan-Samples/pull/1245#issuecomment-2543841150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5IAY5GTTQPFW4IMNI3IXD2FVT33AVCNFSM6AAAAABTPUCXZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTHA2DCMJVGA . You are receiving this because you authored the thread.Message ID: @.***>

[gary-sweet]

This doesn't appear to break the build for me, but that's about all I can tell you since we don't support video.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}