Vulkan-Samples icon indicating copy to clipboard operation
Vulkan-Samples copied to clipboard

Android building: Could NOT find Adb

Open mandagod opened this issue 1 year ago • 6 comments

CMake Error at /Users/XXX/Library/Android/sdk/cmake/3.22.1/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find Adb (missing: ADB_EXECUTABLE) (Required is at least version "1.0.39") Call Stack (most recent call first): /Users/XXX/Library/Android/sdk/cmake/3.22.1/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE) /Users/XXX/Documents/Docs/vulkan/Vulkan-Samples/bldsys/cmake/module/FindAdb.cmake:50 (find_package_handle_standard_args) /Users/XXX/Documents/Docs/vulkan/Vulkan-Samples/bldsys/cmake/android_sync_folder.cmake:26 (find_package)

mandagod avatar Oct 09 '24 07:10 mandagod

Fix the issue: find_package(Adb 1.0.39 REQUIRED) update to find_package(adb 1.0.39 REQUIRED), case sensitive.

mandagod avatar Oct 09 '24 07:10 mandagod

Another issue is: shader files are not automatically packaged in APK. For example can't find the triangle.vert

mandagod avatar Oct 09 '24 07:10 mandagod

Shader files are packaged as part of the apk build process. What sample does fail?

SaschaWillems avatar Oct 09 '24 18:10 SaschaWillems

Shader files are packaged as part of the apk build process. What sample does fail?

BUILD SUCCESSFULLY. But None of the shader files are packaged into the apk.

mandagod avatar Oct 10 '24 02:10 mandagod

Did you sync the files as noted in https://github.com/KhronosGroup/Vulkan-Samples/blob/main/docs/build.adoc#3d-models?

SaschaWillems avatar Oct 11 '24 07:10 SaschaWillems

Did you sync the files as noted in https://github.com/KhronosGroup/Vulkan-Samples/blob/main/docs/build.adoc#3d-models?

Fine, it will fix issue. Thx

mandagod avatar Oct 11 '24 08:10 mandagod

The spelling of "Adb" is right in this case. That's not the name of the "adb" binary, but rather the "FindAdb.cmake" file, so spelling has to match. That script does indeed look for adb with lower case.

SaschaWillems avatar Nov 16 '24 16:11 SaschaWillems