Vulkan-Samples icon indicating copy to clipboard operation
Vulkan-Samples copied to clipboard

Add new sample for VK_EXT_host_image_copy

Open SaschaWillems opened this issue 1 year ago • 4 comments

Description

This PR adds a new sample for the VK_EXT_host_image_copy. It shows how to replace traditional image staging with host image copies and also comes with a tutorial on how to use this extension.

I have tested the sample on Windows 11 with an nvidia RTX 4070.

Fixes #1076

General Checklist:

Please ensure the following points are checked:

  • [x] My code follows the coding style
  • [x] I have reviewed file licenses
  • [x] I have commented any added functions (in line with Doxygen)
  • [x] I have commented any code that could be hard to understand
  • [x] My changes do not add any new compiler warnings
  • [x] My changes do not add any new validation layer errors or warnings
  • [x] I have used existing framework/helper functions where possible
  • [x] My changes do not add any regressions
  • [x] I have tested every sample to ensure everything runs correctly
  • [x] This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • [x] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • [x] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • [x] I have tested the sample on at least one compliant Vulkan implementation
  • [x] If the sample is vendor-specific, I have tagged it appropriately
  • [x] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • [x] Any dependent assets have been merged and published in downstream modules
  • [x] For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • [x] For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • [x] For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

SaschaWillems avatar Jul 27 '24 15:07 SaschaWillems

The sample runs fine for me, just a few minor comments on the documentation.

gary-sweet avatar Jul 29 '24 09:07 gary-sweet

Thank you very much for your review. I have incorporated your suggestions :)

SaschaWillems avatar Aug 11 '24 07:08 SaschaWillems

I have incorporated your suggestions

Have you? You just adjusted the copyrights.

asuessenbach avatar Aug 12 '24 10:08 asuessenbach

My bad. I forgot to actually commit the other changes. Please check again.

SaschaWillems avatar Aug 12 '24 14:08 SaschaWillems

Merging - 3 approvals

marty-johnson59 avatar Sep 06 '24 16:09 marty-johnson59