Vulkan-Loader icon indicating copy to clipboard operation
Vulkan-Loader copied to clipboard

Fix API version name handling

Open MathiasMagnus opened this issue 9 months ago • 7 comments

Recent refactoring broke downstream version name handling. These changes have no effect on Vulkan, but enables proper handling for Vulkan SC.

MathiasMagnus avatar Mar 18 '25 16:03 MathiasMagnus

Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build.

ci-tester-lunarg avatar Mar 18 '25 16:03 ci-tester-lunarg

Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build.

ci-tester-lunarg avatar Mar 18 '25 16:03 ci-tester-lunarg

CI Vulkan-Loader build queued with queue ID 405299.

ci-tester-lunarg avatar Mar 26 '25 15:03 ci-tester-lunarg

CI Vulkan-Loader build # 2994 running.

ci-tester-lunarg avatar Mar 26 '25 15:03 ci-tester-lunarg

Seems that recent changes cause this PR to need rebasing. I could try rebasing it but I would rather let the people who have the downstream usage of Vulkan-Loader be the ones to do it.

charles-lunarg avatar Mar 26 '25 15:03 charles-lunarg

CI Vulkan-Loader build # 2994 passed.

ci-tester-lunarg avatar Mar 26 '25 15:03 ci-tester-lunarg

I went ahead and rebased locally to see what the conflicts are - seems that spencer switched '' and "" in a recent PR. So its a very simple conflict to fix thankfully. I don't have permissions to push it to the fork/branch, but I am happy to make the rebased PR available.

charles-lunarg avatar Mar 31 '25 16:03 charles-lunarg

Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build.

ci-tester-lunarg avatar Jun 03 '25 13:06 ci-tester-lunarg

Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build.

ci-tester-lunarg avatar Jun 03 '25 13:06 ci-tester-lunarg

@charles-lunarg I've rebased the scripts on top of latest main. Please consider merging should CI run and finish correctly.

MathiasMagnus avatar Jun 03 '25 13:06 MathiasMagnus

CI Vulkan-Loader build queued with queue ID 456994.

ci-tester-lunarg avatar Jun 03 '25 16:06 ci-tester-lunarg

CI Vulkan-Loader build # 3051 running.

ci-tester-lunarg avatar Jun 03 '25 16:06 ci-tester-lunarg

CI Vulkan-Loader build # 3051 passed.

ci-tester-lunarg avatar Jun 03 '25 16:06 ci-tester-lunarg