Vulkan-Loader icon indicating copy to clipboard operation
Vulkan-Loader copied to clipboard

terminator_CreateSharedSwapchainsKHR() is broken

Open jjulianoatnv opened this issue 6 months ago • 1 comments

By code inspection of terminator_CreateSharedSwapchainsKHR(), it appears that this function cannot possibly function as intended.

Around here: https://github.com/KhronosGroup/Vulkan-Loader/blob/83cd92c725987857a84c871bd8bc11b249d239b1/loader/wsi.c#L2087

icd_surface is assigned from the first array member of pCreateInfos. Next is a loop over the count of pCreateInfos that unpacks the loader's wrapped VkSuraceKHR, replacing it with the ICD's own VkSurfaceKHR. Only the first loop iteration performs this unpacking using the correct icd_surface. The rest of the loop iterations use the wrong icd_surface.

jjulianoatnv avatar Aug 14 '24 12:08 jjulianoatnv