VK-GL-CTS icon indicating copy to clipboard operation
VK-GL-CTS copied to clipboard

VK-GL-CTS-opengl-cts-4.6.2 check gltextureParameter* return error enum inconsistent with the ogl spec

Open Happybqj opened this issue 2 years ago • 3 comments

In gl4cDirectStateAccessTexturesTests.cpp, there are some gltextureParameter* error enum check not same with ogl spec: In line12141, line12269, line12393, line12517, line12641, line12764, INVALID_ENUM is generated by TextureParameter* if the effective target is either TEXTURE_2D_MULTISAMPLE or TEXTURE_2D_MULTISAMPLE_ARRAY, and pname is any of the sampler states.

Happybqj avatar Sep 13 '22 07:09 Happybqj

According to 4.6 spec (8.10. TEXTURE PARAMETERS):

An INVALID_OPERATION error is generated by TextureParameter* if
the effective target is either TEXTURE_2D_MULTISAMPLE or TEXTURE_2D_-
MULTISAMPLE_ARRAY, and pname is any sampler state from table 23.18.

For me It looks like the checks are correct but some of the comments refer error code for TexParameter* (INVALID_ENUM) and not for TextureParameter* (INVALID_OPERATION).

tpalli avatar Sep 15 '22 05:09 tpalli

@Happybqj Thanks for reporting, would you be able to upload a PR to fix the comments?

mnetsch avatar Sep 15 '22 20:09 mnetsch

Done. @mnetsch

Happybqj avatar Dec 16 '22 08:12 Happybqj